Revert "[WSLC] Add cooperative HTTP/HTTPS proxy support" - #697
Merged
Soham Das (SohamDas2021) merged 1 commit intoJul 28, 2026
Merged
Conversation
This reverts commit 3b910d9.
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Huzaifa Danish (huzaifa-d)
approved these changes
Jul 28, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Reverts WSLC cooperative proxy support to unblock the GA network schema migration in PR #676.
Changes:
- Removes WSLC proxy parsing, environment injection, tests, and documentation.
- Deletes shared proxy utilities and restores Bubblewrap-local handling.
- Restores the previous public SDK network documentation.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
docs/schema.md |
Removes WSLC proxy guidance. |
docs/wsl/wsl-container-getting-started.md |
Removes WSLC proxy documentation. |
sdk/node/src/types.ts |
Removes WSLC proxy API notes. |
src/backends/bubblewrap/common/src/bwrap_command.rs |
Restores local proxy environment handling. |
src/backends/wslc/common/src/wsl_container_runner.rs |
Removes WSLC proxy injection. |
src/core/wxc_common/src/config_parser.rs |
Rejects WSLC proxy configurations again. |
src/core/wxc_common/src/lib.rs |
Removes the proxy utility module export. |
src/core/wxc_common/src/proxy_env.rs |
Deletes shared proxy environment utilities. |
tests/configs/wslc_network_proxy.json |
Removes the WSLC proxy fixture. |
tests/scripts/run_wslc_all_tests.ps1 |
Removes proxy testing from the WSLC suite. |
tests/scripts/run_wslc_proxy_test.ps1 |
Deletes the proxy functional test. |
Comment on lines
+978
to
+979
| if !request.env.is_empty() { | ||
| let env_cstrings: Vec<Vec<u8>> = request |
| // When the proxy is active, drop any caller-supplied proxy env | ||
| // entries so they cannot override the values we set below. | ||
| if proxy_address.is_some() && is_managed_proxy_key(key) { | ||
| if proxy_address.is_some() && PROXY_ENV_KEYS.contains(&key) { |
Soham Das (SohamDas2021)
deleted the
revert-652-user/sodas/wslc-enable-http-proxy
branch
July 28, 2026 21:03
Soham Das (SohamDas2021)
added a commit
that referenced
this pull request
Jul 30, 2026
* Reapply "[WSLC] Add cooperative HTTP/HTTPS proxy support" (#697) This reverts commit ea8f405, restoring the WSLC cooperative HTTP/HTTPS proxy support originally added in #652. Resolved a trivial conflict in config_parser.rs (proxy-supported-backends error message) by keeping the 'wslc' variant. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: cce70ecd-1449-465e-8a87-a9880a0a10c0 * Redact proxy URL credentials in scheme-rejection error The `network.proxy.url` scheme check interpolated the raw URL into the `ConfigParse` error, which reaches the diagnostic/log stream. Proxy URLs commonly embed basic-auth userinfo (`user:password@host`), so a rejected non-http(s) URL would leak the password into logs. Route it through the existing `redact_proxy_url` helper (already used on the logging path) so only `***@host` is shown. Add a regression test asserting the credential is redacted. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: cce70ecd-1449-465e-8a87-a9880a0a10c0 --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: cce70ecd-1449-465e-8a87-a9880a0a10c0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #652
This is conflicting with Darren's new breaking network schema changes- #676
I am reverting this, will be merging after his changes go in.
Microsoft Reviewers: Open in CodeFlow