Add iso session test bundle for os vpack - #692
Merged
Branden Bonaby (bbonaby) merged 11 commits intoJul 30, 2026
Merged
Conversation
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Azure pipelines to build, sign, publish, and package IsolationSession test bundles from main and feature branches.
Changes:
- Builds x64 IsolationSession binaries and test collateral.
- Publishes signed main and feature artifacts.
- Stages both artifacts into the OS VPack.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
.azure-pipelines/templates/Vpack.Package.Job.yml |
Downloads and stages both test bundles. |
.azure-pipelines/templates/IsolationSession.TestBundle.Build.Job.yml |
Builds, signs, and publishes each bundle. |
.azure-pipelines/1ES.IsolationSession.TestBundle.yml |
Defines the two-branch bundle pipeline. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
.azure-pipelines/templates/IsolationSession.TestBundle.Build.Job.yml:187
branch_nameis populated with the repository resource alias (mxc_mainormxc_iso_session_feature), not the branch that produced the bundle. This makes the new provenance manifest inaccurate—for example, the feature artifact cannot identifyfeature/isolation-session-internal. Pass the configured branch/ref into this template and record that value here (or rename this field torepository_aliasif the alias is what consumers need).
produced_at = (Get-Date).ToUniversalTime().ToString('o')
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
.azure-pipelines/templates/IsolationSession.TestBundle.Build.Job.yml:188
checkoutRepois the Azure repository alias (mxc_mainormxc_iso_session_feature), not the checked-out branch. The emittedbranch_nametherefore records incorrect provenance instead ofmainorfeature/isolation-session-internal. Pass the configured branch/ref into this template separately (or rename this manifest field if the alias is what consumers need).
branch_name = "${{ parameters.checkoutRepo }}"
.azure-pipelines/templates/IsolationSession.TestBundle.Build.Job.yml:55
- This adds a third hard-coded official Rust toolchain pin, but
.github/copilot-instructions.md:5still tells maintainers to update only the two existing*.Build.Job.ymlpins. The next toolchain bump can leave this test-bundle pipeline on an old compiler. Update that documented synchronization rule in this PR, or centralize the pin so all official jobs consume one value.
version: 'ms-prod-1.93'
Dan Legg (danlegg)
approved these changes
Jul 29, 2026
Soham Das (SohamDas2021)
approved these changes
Jul 30, 2026
Branden Bonaby (bbonaby)
deleted the
user/bbonaby/add-iso-session-vpack-detail
branch
July 30, 2026 22:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
The isolation session team needs to be able to run mxc from both main and their feature branch in windows nightly test passes to confirm their new features/refactors don't break MXC. They also want to test out experimental features for the iso session backend that may not be on Windows insider builds yet to confirm functionality with MXC before they check into main. These additions are done via their feature/isolation_session_feature-internal branch in the MXC repo. This PR adds the azure templates needed to package up wxc-exec, iso session configs and scripts from both main branch and the feature branch so they can be packaged into our Vpack.
🔗 References
🔍 Validation
✅ Checklist
Cargo.lock, thedependency-feed-checkcheck passes (see docs/pull-requests.md)📋 Issue Type
GitHub Actions runs the PR validation build automatically. The ADO pipeline
(
MXC-PR-Build) is the Azure version of the PR pipeline, kept in parity with the GitHubActions build; it runs on merge to
main, and Microsoft reviewers with write access can trigger iton a PR with
/azp run. See docs/pull-requests.md.If the
dependency-feed-checkcheck fails on a new dependency, the crate must be added tothe feed before the PR can pass. See docs/pull-requests.md
for the steps.
Microsoft Reviewers: Open in CodeFlow