-
Notifications
You must be signed in to change notification settings - Fork 56
Enable one-click crates.io release for mxc-sdk (ESRP) [in-repo, supersedes #647] #689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
b2e6f36
Make the mxc-sdk crate closure publishable to crates.io
dhoehna bf82cd1
Add one-click crates.io release pipeline for mxc-sdk
dhoehna d27c0f0
Merge microsoft/mxc main (47a172c) into crate-release-pipeline
dhoehna a39e647
ci(crates): release crates.io through ESRP in 1ES.Release.yml
dhoehna d5bbcb3
fix(crates): package the whole closure in one cargo invocation
dhoehna cfaaf18
fix(crates): check the private Azure feed index, not public crates.io
dhoehna 287305b
ci(crates): address review feedback (gate, defaults, dry-run, trim)
dhoehna 237abe6
Merge microsoft/mxc main into user/dahoehna/crate-release-pipeline
dhoehna daa619e
fix(crates): pass --registry crates-io to cargo package
dhoehna File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes the existing release pipeline's default behavior:
publishNpmis now false, whilepublishCratesis also false. A default queue operation that previously published npm now selects no publication target (and may leave the expandedstageslist empty, depending on template validation).Please either preserve the npm default or add an unconditional validation stage that fails clearly when neither target is selected, so the default run cannot silently become a no-op.