-
Notifications
You must be signed in to change notification settings - Fork 54
Permissive Learning Mode 2/6 filesystem extraction #585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lilybarkley-msft
wants to merge
9
commits into
main
Choose a base branch
from
user/lilybarkley/plm-pr2-fs-extraction
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
7f62d08
plm(pr2): fold in review fixes originally staged for pr1
lilybarkley-msft 09f3607
PLM split PR2: filesystem extraction
lilybarkley-msft abdf8f6
plm: copy input config to log_dir unconditionally
lilybarkley-msft fcb38d1
plm: load config once up front, edit in memory, decouple from copy
lilybarkley-msft 9c47494
plm(pr2): address code-review findings
lilybarkley-msft 175928c
plm(pr2): additional review-fix pass
lilybarkley-msft fc9583d
plm(pr2): third review-fix pass (PR 585 open comments)
lilybarkley-msft 08dbc86
plm(pr2): fourth review-fix pass (MGudgin comments)
lilybarkley-msft 1efc888
plm(pr2): fifth review-fix pass (MGudgin config.rs:311)
lilybarkley-msft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| //! Port of the `LearningModeAccessEvent` PowerShell class from | ||
| //! `stop_plm_logging.ps1`. One file-access record from a PLM WPR trace. | ||
|
|
||
| use chrono::{DateTime, Utc}; | ||
|
|
||
| #[derive(Debug, Clone)] | ||
| // Fields kept for parity with the PowerShell version even though the | ||
| // orchestrator currently only uses file_path and access_mask. | ||
| #[allow(dead_code)] | ||
| pub struct LearningModeAccessEvent { | ||
|
Comment on lines
+7
to
+10
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. question: Are all these needed now that the powershell version is no more? Or are they gonna be used in a future PR? |
||
| pub time_created: DateTime<Utc>, | ||
| pub process_id: u32, | ||
| pub thread_id: u32, | ||
| pub learning_mode: String, // Permissive/Enforcing | ||
| pub resource_type: String, // File/Directory | ||
| pub file_path: String, | ||
| pub app_path: String, | ||
| pub access_mask: u32, | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The README still describes the blank-config preview as future work in three places, but it is already implemented and active in this PR.
Line 15 says "The Adjusted_*.json writer arrives in the next PR; this PR only prints the per-event summary." Line 61 says "The diff against a blank config preview arrives in later PRs." Both are stale. log.rs (lines 85-108) already merges extracted paths into a blank config and prints the resulting JSON as the actual current output of plm log, not a future feature.
Line 24's table entry for src/log.rs, "Interactive mode: Enter to start, Enter to stop, then diff vs a blank config," is also inconsistent with the surrounding text since it describes the diff as already happening while line 61 says it is still future work.
Fix: Update the README to document the current "blank config after merge" output that log.rs actually produces today, and remove the stale future-work wording in both places. The Adjusted_*.json writer claim in line 15 is a separate, still-accurate future-work statement (see the CLI help finding for main.rs) and should stay, but should not be conflated with the blank-config preview, which is already shipped.