Remove stale TS CLI References#539
Conversation
There was a problem hiding this comment.
⚠️ Not ready to approve
The updated doc section still states TypeScript targets ES2020/CommonJS, which conflicts with the SDK’s current ES2022/NodeNext (ESM) configuration and should be corrected while touching this area.
Pull request overview
This PR updates the repository’s contributor instructions by removing stale references to a TypeScript CLI that no longer exists in this repo, keeping .github/copilot-instructions.md aligned with the current project structure (Rust core + TypeScript SDK).
Changes:
- Removes CLI-specific build, lint, and test commands from the Copilot instructions.
- Updates wording to describe the TypeScript layer as SDK-only (not SDK/CLI).
- Tweaks the Linux
--rust-onlydescription to reflect skipping the SDK (not SDK/CLI).
File summaries
| File | Description |
|---|---|
| .github/copilot-instructions.md | Removes stale TypeScript CLI references from build/lint/test guidance and updates architecture wording to SDK-only. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
Note
Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.
0c2726b to
e4cdbd4
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
e4cdbd4 to
e4eff33
Compare
|
I think for this one it's because we have .md files set to ignore in here: mxc/.github/workflows/Build.yml Line 19 in b19e812 But then in the Github actions in the settings for the repository, I have all the GitHub actions set to mxc/.azure-pipelines/1ES.Build.yml Line 16 in b19e812 That's why when you commented azp run the bot said Azure Pipelines could not run because the pipeline triggers exclude this branch/path.
We don't require the azure pipelines to succeed before merging so that one is fine. Unfortunately the GitHub pipelines will stay stuck forever waiting on the build to run even though we have these paths set to ignore. E.g Github waiting for required pipelines to succeed but they never run because they're skipped. You can see the required status checks here: https://github.com/microsoft/mxc/rules/16396467 under We could remove the OR We can add a bypass to the PR rule. Note: the PR rule is really just to make sure the pipelines are required to pass at PR time. There is a Microsoft rule that PRs require at least 1 approver which we also have and isn't bypassable here, so effectively bypassing would be just for the PR rule and we can scope it to only a few people with it documented that it should only be used for document changes. I'm good with either two. Thoughts? Note: This one also has the same issue: #545 |
Is a third option to just run the same gates even for 'none code' PRs? If so, I think that is our least worst option. Yes, it means some unnecessary checks run, but it means that we don't have to worry about PRs being merged that have not cleared gates. |
|
yea that's cool with me: Can you approve #549, merge it and then merge with main? That should get the pipelines running again. |
Remove references to the TypeScript CLI from copilot-instructions.md
e4eff33 to
e0c0ebf
Compare
Remove references to the TypeScript CLI from copilot-instructions.md
Microsoft Reviewers: Open in CodeFlow