Align 0.6.0-dev schema with what the parser accepts today by MGudgin · Pull Request #451 · microsoft/mxc

MGudgin · 2026-05-28T21:05:10Z

📖 Description

The dev schema is an editor-validation aid for in-development authors (docs/versioning.md), not a 1:1 mirror of parser behavior. Brought it back in sync with wxc_common::config_parser.

Added fields:

network.proxy.url (third oneOf variant; parser handles it, schema dropped it between 0.5.0-alpha and 0.6.0-dev)
network.allowLocalNetwork (Seatbelt: Honor allowLocalNetwork to permit inbound binds #422)
containment enum entries: vm, hyperlight, bubblewrap
experimental.wslc.portMappings (with required ports and tcp/udp protocol enum)
experimental.seatbelt.extraMachLookups (Seatbelt: Add extraMachLookups escape hatch for additional Mach services #437)
Containment description: note that hyperlight/bubblewrap share the common policy fields (no per-backend block)

Intentionally omitted (parser accepts; schema steers authors to the canonical spelling):

containment aliases appcontainer and macos_sandbox — schema points at processcontainer and seatbelt instead
experimental.windows_sandbox.idleTimeout — legacy alias for idleTimeoutMs, same reasoning
processContainer.learningMode — debug-build-only escape hatch, silently stripped with a SECURITY log line in release; would mislead release-build authors

Parser tightening for experimental.wslc.portMappings:

RawPortMapping ports are now required u16 (were Option, defaulted to 0)
wslc handler rejects port == 0 and protocol other than tcp/udp with WxcError::ConfigParse
5 regression tests added in config_parser::tests

SDK and docs unchanged.

🔗 References

Adds schema coverage for fields introduced by:

Split SDK containment into intent vs. backend, and rename to match #268 (intent/backend split — vm intent was missed in the schema)
Add Hyperlight containment backend (Hyperlight + Unikraft micro-VM) #276 (Hyperlight backend — schema not updated)
Seatbelt: Honor allowLocalNetwork to permit inbound binds #422 (allowLocalNetwork)
Seatbelt: Add extraMachLookups escape hatch for additional Mach services #437 (extraMachLookups)

🔍 Validation

cargo check --manifest-path src/wxc_common/Cargo.toml clean
cargo test --manifest-path src/wxc_common/Cargo.toml config_parser — 141 passed, 0 failed (includes the 5 new wslc_port_mappings_* tests)
No existing test_configs/ fixtures reference portMappings, so the parser tightening has zero blast radius on existing test data
Manual: hand-verified each schema description against parser behavior

✅ Checklist

Signed the Contributor License Agreement
Linked to an issue
Updated documentation (if applicable) — n/a, description text on the schema fields documents the intentional asymmetries
Updated Copilot instructions (if build, architecture, or conventions changed)

📋 Issue Type

Bug fix

🤖 Generated with Claude Code

Microsoft Reviewers: Open in CodeFlow

The dev schema is an editor-validation aid for in-development authors (docs/versioning.md), not a 1:1 mirror of parser behavior. Brought it back in sync with wxc_common::config_parser. Added fields: - network.proxy.url (third oneOf variant; parser handles it, schema dropped it between 0.5.0-alpha and 0.6.0-dev) - network.allowLocalNetwork (#422) - containment enum entries: vm, hyperlight, bubblewrap - experimental.wslc.portMappings (with required ports and tcp/udp protocol enum) - experimental.seatbelt.extraMachLookups (#437) - Containment description: note that hyperlight/bubblewrap share the common policy fields (no per-backend block) Intentionally omitted (parser accepts; schema steers authors to the canonical spelling): - containment aliases 'appcontainer' and 'macos_sandbox' — schema points at 'processcontainer' and 'seatbelt' instead - experimental.windows_sandbox.idleTimeout — legacy alias for idleTimeoutMs, same reasoning - processContainer.learningMode — debug-build-only escape hatch, silently stripped with a SECURITY log line in release; would mislead release- build authors Parser tightening for experimental.wslc.portMappings: - RawPortMapping ports are now required u16 (were Option, defaulted to 0) - wslc handler rejects port == 0 and protocol other than 'tcp'/'udp' with WxcError::ConfigParse - 5 regression tests added in config_parser::tests SDK and docs unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Copilot

Pull request overview

Aligns the in-development 0.6.0-dev JSON schema with what wxc_common::config_parser actually accepts, and tightens parsing of experimental.wslc.portMappings so invalid forwards are rejected at parse time instead of silently defaulting to port 0.

Changes:

Schema: adds network.proxy.url oneOf branch, network.allowLocalNetwork, containment enum entries (vm, hyperlight, bubblewrap), experimental.wslc.portMappings, experimental.seatbelt.extraMachLookups, and documents intentional aliases/omissions.
Parser: makes RawPortMapping.windows_port / container_port required u16 (no Default), and rejects port 0 or non-tcp/udp protocol with WxcError::ConfigParse.
Tests: 5 new wslc_port_mappings_* regression tests covering happy path, default protocol, missing port, zero port, and invalid protocol.

Show a summary per file

File	Description
`schemas/dev/mxc-config.schema.0.6.0-dev.json`	Adds missing fields/enums/descriptions to bring the dev schema back in sync with parser behavior.
`src/wxc_common/src/config_parser.rs`	Tightens `RawPortMapping` to required ports, validates port range and protocol, and adds regression tests.

Copilot's findings

Files reviewed: 2/2 changed files
Comments generated: 0

MGudgin · 2026-05-28T21:23:26Z

Run ADO build please

bbonaby · 2026-05-28T21:30:16Z

/azp run

azure-pipelines · 2026-05-28T21:30:31Z

Azure Pipelines successfully started running 1 pipeline(s).

bbonaby · 2026-05-28T22:54:01Z

+      ],
      "default": "processcontainer",
-      "description": "Containment value to use for execution. Accepts both abstract intents ('process', 'microvm') and concrete backends ('processcontainer', 'windows_sandbox', 'lxc', 'microvm', 'wslc', 'seatbelt', 'isolation_session', 'bubblewrap'). The native binary resolves abstract intents to a concrete backend at run time based on host capabilities. Note: 'windows_sandbox', 'wslc', 'seatbelt', 'isolation_session', and 'bubblewrap' are experimental and require the --experimental CLI flag."
+      "description": "Containment value to use for execution. Accepts both abstract intents ('process', 'vm') and concrete backends ('processcontainer', 'windows_sandbox', 'lxc', 'microvm', 'hyperlight', 'wslc', 'seatbelt', 'isolation_session', 'bubblewrap'). The native binary resolves abstract intents to a concrete backend at run time based on host capabilities (e.g., 'process' resolves to ProcessContainer on Windows, LXC on Linux, Seatbelt on macOS; 'vm' resolves to Windows Sandbox on Windows). Note: 'windows_sandbox', 'wslc', 'seatbelt', 'isolation_session', 'hyperlight', and 'bubblewrap' are experimental and require the --experimental CLI flag. 'hyperlight' and 'bubblewrap' have no per-backend configuration block; they share the common filesystem/network policy fields. The legacy aliases 'appcontainer' and 'macos_sandbox' are still accepted by the parser (with a deprecation log line) but are intentionally omitted from this enum so editors steer authors toward the canonical names."


question (non-blocking): I wonder if this description may be too implementation heavy, since as we add more backends it'd continue to grow.

PR #451 (the merged "Align 0.6.0-dev schema with what the parser accepts today" PR — formerly this stack's branch 1) was tightened during review in three ways the previous publish commit didn't pick up. Mirroring those refinements into the stable 0.6.0-alpha schema keeps the two files consistent: 1. containment enum: drop legacy aliases 'appcontainer' and 'macos_sandbox'. The parser still accepts them (with a deprecation log line) but the schema intentionally omits them so editors steer authors toward 'processcontainer' / 'seatbelt'. The enum description is updated to call this out. 2. experimental.windows_sandbox: drop the 'idleTimeout' legacy alias. Same rationale — the parser still accepts it, but the schema only advertises the canonical 'idleTimeoutMs'. Description rewritten to mention the alias is parser-accepted but schema-omitted. 3. experimental.wslc.portMappings: tighten the item schema with `required: ["windowsPort", "containerPort"]` and `additionalProperties: false` so editors flag missing or unknown keys instead of silently accepting them. No behaviour change — the parser already enforces these shapes; this just brings the editor-validation surface in line with the merged dev schema. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings May 28, 2026 21:05

Copilot started reviewing on behalf of MGudgin May 28, 2026 21:05 View session

Copilot AI reviewed May 28, 2026

View reviewed changes

bbonaby approved these changes May 28, 2026

View reviewed changes

MGudgin merged commit fee3ac2 into main May 28, 2026
21 checks passed

MGudgin deleted the user/gudge/schema/fix-0.6.0-dev-to-match-parser branch May 28, 2026 23:56

MGudgin mentioned this pull request May 29, 2026

Publish 0.6.0-alpha as the new stable schema (strict surface) #455

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Align 0.6.0-dev schema with what the parser accepts today#451

Align 0.6.0-dev schema with what the parser accepts today#451
MGudgin merged 1 commit into
mainfrom
user/gudge/schema/fix-0.6.0-dev-to-match-parser

MGudgin commented May 28, 2026 •

edited by microsoft-github-policy-service Bot

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

MGudgin commented May 28, 2026

Uh oh!

bbonaby commented May 28, 2026

Uh oh!

azure-pipelines Bot commented May 28, 2026

Uh oh!

bbonaby May 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

MGudgin commented May 28, 2026 • edited by microsoft-github-policy-service Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📖 Description

🔗 References

🔍 Validation

✅ Checklist

📋 Issue Type

Microsoft Reviewers: Open in CodeFlow

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

MGudgin commented May 28, 2026

Uh oh!

bbonaby commented May 28, 2026

Uh oh!

azure-pipelines Bot commented May 28, 2026

Uh oh!

bbonaby May 28, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MGudgin commented May 28, 2026 •

edited by microsoft-github-policy-service Bot

Loading