Rename CodexRequest to ExecutionRequest#447
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request renames the Rust validated internal execution model CodexRequest to ExecutionRequest across the Rust workspace and updates documentation references to match, aligning the type name with its role as the request consumed by ScriptRunner implementations.
Changes:
- Renamed
CodexRequest→ExecutionRequestin the core model and updated all Rust call sites (runners, dispatcher, parser, validators, tests). - Updated docs and repo instructions to reference
ExecutionRequestinstead of the historicalCodexRequestname. - Applied formatting adjustments where signatures/comments wrapped due to the rename.
Show a summary per file
| File | Description |
|---|---|
| src/wxc/src/main.rs | Updates CLI logging/imports to use ExecutionRequest. |
| src/wxc_common/src/windows_sandbox_runner.rs | Updates runner trait signatures to ExecutionRequest. |
| src/wxc_common/src/validator.rs | Updates common validation helpers/tests to ExecutionRequest. |
| src/wxc_common/src/state_aware_request.rs | Updates state-aware request types to carry ExecutionRequest. |
| src/wxc_common/src/state_aware_dispatch.rs | Updates dispatcher tests/stubs to ExecutionRequest. |
| src/wxc_common/src/state_aware_backend.rs | Updates state-aware backend trait signatures/tests to ExecutionRequest. |
| src/wxc_common/src/script_runner.rs | Updates ScriptRunner trait to accept ExecutionRequest. |
| src/wxc_common/src/nanvix_runner.rs | Updates NanVix runner validation/execute signatures and tests. |
| src/wxc_common/src/models.rs | Renames the core struct to ExecutionRequest and its Default impl. |
| src/wxc_common/src/isolation_session/state_aware.rs | Updates IsolationSession state-aware backend to ExecutionRequest. |
| src/wxc_common/src/isolation_session/process_options.rs | Updates process options builder to accept ExecutionRequest. |
| src/wxc_common/src/isolation_session/policy.rs | Updates policy validation helpers to accept ExecutionRequest. |
| src/wxc_common/src/isolation_session/one_shot.rs | Updates one-shot IsolationSession runner signatures/tests. |
| src/wxc_common/src/hyperlight_runner.rs | Updates Hyperlight runner validation/execute signatures and tests. |
| src/wxc_common/src/dispatcher.rs | Updates BaseContainer fallback dispatcher APIs to ExecutionRequest. |
| src/wxc_common/src/diagnostic.rs | Updates diagnostic redaction helper signature to ExecutionRequest. |
| src/wxc_common/src/config_parser.rs | Updates parser output/conversion path to produce ExecutionRequest. |
| src/wxc_common/src/base_container_runner.rs | Updates BaseContainer runner APIs/tests to ExecutionRequest. |
| src/wxc_common/src/appcontainer_runner.rs | Updates AppContainer runner internals to ExecutionRequest. |
| src/wslc_common/src/wsl_container_runner.rs | Updates WSLC runner APIs to ExecutionRequest. |
| src/seatbelt_common/src/seatbelt_runner.rs | Updates Seatbelt runner APIs/tests to ExecutionRequest. |
| src/seatbelt_common/src/profile_builder.rs | Updates profile builder APIs to ExecutionRequest. |
| src/seatbelt_common/Cargo.toml | Updates dependency comment to reflect ExecutionRequest. |
| src/mxc_darwin/src/main.rs | Updates macOS binary logging/runner calls to ExecutionRequest. |
| src/lxc/src/main.rs | Updates Linux binary logging/imports to ExecutionRequest. |
| src/lxc_common/src/lxc_runner.rs | Updates LXC runner execute/internal APIs to ExecutionRequest. |
| src/bwrap_common/src/lib.rs | Updates crate docs to reference ExecutionRequest. |
| src/bwrap_common/src/bwrap_runner.rs | Updates Bubblewrap runner APIs to ExecutionRequest. |
| src/bwrap_common/src/bwrap_command.rs | Updates Bubblewrap arg builder to accept ExecutionRequest. |
| docs/wsl/wsl-container-support-plan.md | Updates WSL docs to reference ExecutionRequest. |
| docs/versioning.md | Updates versioning docs examples to ExecutionRequest. |
| docs/state-aware-lifecycle/mxc-state-aware-sandbox-api.md | Updates state-aware API reference to ExecutionRequest. |
| docs/state-aware-lifecycle/mxc-state-aware-sandbox-api-overview.md | Updates overview doc to ExecutionRequest. |
| docs/nanvix-microvm/nanvix-integration-plan.md | Updates NanVix docs mapping to ExecutionRequest. |
| docs/isolation-session/initial-bringup-plan.md | Updates IsolationSession plan doc to ExecutionRequest. |
| docs/diagnostics.md | Updates diagnostics docs to reference ExecutionRequest. |
| docs/bwrap-support/bubblewrap-backend-plan.md | Updates Bubblewrap plan doc snippets to ExecutionRequest. |
| docs/base-process-container/guide.md | Updates BaseContainer guide snippet to ExecutionRequest. |
| docs/authoring-a-new-feature.md | Updates feature-authoring doc snippets to ExecutionRequest. |
| .github/copilot-instructions.md | Updates internal docs to reference ExecutionRequest in config flow. |
Copilot's findings
- Files reviewed: 40/40 changed files
- Comments generated: 8
MGudgin
force-pushed
the
user/gudge/rename-codex-request
branch
3 times, most recently
from
May 28, 2026 04:59
ce9f75e to
0163aa4
Compare
The Rust struct `CodexRequest` in `src/wxc_common/src/models.rs` is the validated, internal execution model that `Raw*` config-parser structs are mapped to and that `ScriptRunner` implementations consume. The name `Codex` is a historical holdover and no longer reflects what the type represents. `ExecutionRequest` matches the "request handed to a `ScriptRunner` for execution" mental model and keeps the layered Policy → Config → Runner vocabulary already used in the codebase clean: | Layer | Type | |---------------------------------|---------------------| | High-level user intent (TS SDK) | `SandboxPolicy` | | Wire format (TS → JSON) | `ContainerConfig` | | Permissive parse (Rust) | `Raw*` structs | | Validated internal form (Rust) | `ExecutionRequest` | Closes #446 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
MGudgin
force-pushed
the
user/gudge/rename-codex-request
branch
from
May 28, 2026 15:43
0163aa4 to
1170d35
Compare
richiemsft
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames the Rust struct
CodexRequesttoExecutionRequestacross the workspace.CodexRequestis the validated, internal execution model thatRaw*config-parser structs are mapped to and thatScriptRunnerimplementations consume. TheCodexprefix is a historical holdover and no longer reflects what the type represents.ExecutionRequestmatches the "request handed to aScriptRunnerfor execution" mental model and keeps the layered Policy → Config → Runner vocabulary already used in the codebase clean:SandboxPolicyContainerConfigRaw*structsExecutionRequestChanges
docs/versioning.md,docs/authoring-a-new-feature.md,docs/state-aware-lifecycle/*,docs/bwrap-support/*,docs/diagnostics.md,docs/base-process-container/guide.md,docs/wsl/*,docs/nanvix-microvm/*,docs/isolation-session/initial-bringup-plan.md, and.github/copilot-instructions.md).cargo fmtso a few now-longer signature lines wrap correctly.Verification
Ran from
src/:cargo fmt --all -- --check— cleancargo clippy --workspace --all-targets -- -D warnings— cleancargo build --workspace— cleancargo test --workspace --exclude wxc_e2e_tests— all tests passCloses #446
Microsoft Reviewers: Open in CodeFlow