Skip to content

Rename CodexRequest to ExecutionRequest#447

Merged
MGudgin merged 1 commit into
mainfrom
user/gudge/rename-codex-request
May 28, 2026
Merged

Rename CodexRequest to ExecutionRequest#447
MGudgin merged 1 commit into
mainfrom
user/gudge/rename-codex-request

Conversation

@MGudgin

@MGudgin MGudgin commented May 28, 2026

Copy link
Copy Markdown
Member

Summary

Renames the Rust struct CodexRequest to ExecutionRequest across the workspace.

CodexRequest is the validated, internal execution model that Raw* config-parser structs are mapped to and that ScriptRunner implementations consume. The Codex prefix is a historical holdover and no longer reflects what the type represents. ExecutionRequest matches the "request handed to a ScriptRunner for execution" mental model and keeps the layered Policy → Config → Runner vocabulary already used in the codebase clean:

Layer Type
High-level user intent (TS SDK) SandboxPolicy
Wire format (TS → JSON) ContainerConfig
Permissive parse (Rust) Raw* structs
Validated internal form (Rust) ExecutionRequest

Changes

  • Renamed the struct definition and all references across the Rust workspace (303 textual replacements across 40 files).
  • Updated documentation that referenced the old name (docs/versioning.md, docs/authoring-a-new-feature.md, docs/state-aware-lifecycle/*, docs/bwrap-support/*, docs/diagnostics.md, docs/base-process-container/guide.md, docs/wsl/*, docs/nanvix-microvm/*, docs/isolation-session/initial-bringup-plan.md, and .github/copilot-instructions.md).
  • Applied cargo fmt so a few now-longer signature lines wrap correctly.

Verification

Ran from src/:

  • cargo fmt --all -- --check — clean
  • cargo clippy --workspace --all-targets -- -D warnings — clean
  • cargo build --workspace — clean
  • cargo test --workspace --exclude wxc_e2e_tests — all tests pass

Closes #446

Microsoft Reviewers: Open in CodeFlow

Copilot AI review requested due to automatic review settings May 28, 2026 04:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request renames the Rust validated internal execution model CodexRequest to ExecutionRequest across the Rust workspace and updates documentation references to match, aligning the type name with its role as the request consumed by ScriptRunner implementations.

Changes:

  • Renamed CodexRequestExecutionRequest in the core model and updated all Rust call sites (runners, dispatcher, parser, validators, tests).
  • Updated docs and repo instructions to reference ExecutionRequest instead of the historical CodexRequest name.
  • Applied formatting adjustments where signatures/comments wrapped due to the rename.
Show a summary per file
File Description
src/wxc/src/main.rs Updates CLI logging/imports to use ExecutionRequest.
src/wxc_common/src/windows_sandbox_runner.rs Updates runner trait signatures to ExecutionRequest.
src/wxc_common/src/validator.rs Updates common validation helpers/tests to ExecutionRequest.
src/wxc_common/src/state_aware_request.rs Updates state-aware request types to carry ExecutionRequest.
src/wxc_common/src/state_aware_dispatch.rs Updates dispatcher tests/stubs to ExecutionRequest.
src/wxc_common/src/state_aware_backend.rs Updates state-aware backend trait signatures/tests to ExecutionRequest.
src/wxc_common/src/script_runner.rs Updates ScriptRunner trait to accept ExecutionRequest.
src/wxc_common/src/nanvix_runner.rs Updates NanVix runner validation/execute signatures and tests.
src/wxc_common/src/models.rs Renames the core struct to ExecutionRequest and its Default impl.
src/wxc_common/src/isolation_session/state_aware.rs Updates IsolationSession state-aware backend to ExecutionRequest.
src/wxc_common/src/isolation_session/process_options.rs Updates process options builder to accept ExecutionRequest.
src/wxc_common/src/isolation_session/policy.rs Updates policy validation helpers to accept ExecutionRequest.
src/wxc_common/src/isolation_session/one_shot.rs Updates one-shot IsolationSession runner signatures/tests.
src/wxc_common/src/hyperlight_runner.rs Updates Hyperlight runner validation/execute signatures and tests.
src/wxc_common/src/dispatcher.rs Updates BaseContainer fallback dispatcher APIs to ExecutionRequest.
src/wxc_common/src/diagnostic.rs Updates diagnostic redaction helper signature to ExecutionRequest.
src/wxc_common/src/config_parser.rs Updates parser output/conversion path to produce ExecutionRequest.
src/wxc_common/src/base_container_runner.rs Updates BaseContainer runner APIs/tests to ExecutionRequest.
src/wxc_common/src/appcontainer_runner.rs Updates AppContainer runner internals to ExecutionRequest.
src/wslc_common/src/wsl_container_runner.rs Updates WSLC runner APIs to ExecutionRequest.
src/seatbelt_common/src/seatbelt_runner.rs Updates Seatbelt runner APIs/tests to ExecutionRequest.
src/seatbelt_common/src/profile_builder.rs Updates profile builder APIs to ExecutionRequest.
src/seatbelt_common/Cargo.toml Updates dependency comment to reflect ExecutionRequest.
src/mxc_darwin/src/main.rs Updates macOS binary logging/runner calls to ExecutionRequest.
src/lxc/src/main.rs Updates Linux binary logging/imports to ExecutionRequest.
src/lxc_common/src/lxc_runner.rs Updates LXC runner execute/internal APIs to ExecutionRequest.
src/bwrap_common/src/lib.rs Updates crate docs to reference ExecutionRequest.
src/bwrap_common/src/bwrap_runner.rs Updates Bubblewrap runner APIs to ExecutionRequest.
src/bwrap_common/src/bwrap_command.rs Updates Bubblewrap arg builder to accept ExecutionRequest.
docs/wsl/wsl-container-support-plan.md Updates WSL docs to reference ExecutionRequest.
docs/versioning.md Updates versioning docs examples to ExecutionRequest.
docs/state-aware-lifecycle/mxc-state-aware-sandbox-api.md Updates state-aware API reference to ExecutionRequest.
docs/state-aware-lifecycle/mxc-state-aware-sandbox-api-overview.md Updates overview doc to ExecutionRequest.
docs/nanvix-microvm/nanvix-integration-plan.md Updates NanVix docs mapping to ExecutionRequest.
docs/isolation-session/initial-bringup-plan.md Updates IsolationSession plan doc to ExecutionRequest.
docs/diagnostics.md Updates diagnostics docs to reference ExecutionRequest.
docs/bwrap-support/bubblewrap-backend-plan.md Updates Bubblewrap plan doc snippets to ExecutionRequest.
docs/base-process-container/guide.md Updates BaseContainer guide snippet to ExecutionRequest.
docs/authoring-a-new-feature.md Updates feature-authoring doc snippets to ExecutionRequest.
.github/copilot-instructions.md Updates internal docs to reference ExecutionRequest in config flow.

Copilot's findings

  • Files reviewed: 40/40 changed files
  • Comments generated: 8

Comment thread src/wxc_common/src/diagnostic.rs Outdated
Comment thread src/wxc_common/src/isolation_session/process_options.rs
Comment thread src/wxc_common/src/isolation_session/process_options.rs Outdated
Comment thread src/wxc_common/src/dispatcher.rs Outdated
Comment thread src/bwrap_common/src/bwrap_command.rs Outdated
Comment thread src/seatbelt_common/src/profile_builder.rs Outdated
Comment thread docs/state-aware-lifecycle/mxc-state-aware-sandbox-api.md Outdated
Comment thread docs/state-aware-lifecycle/mxc-state-aware-sandbox-api-overview.md Outdated
@MGudgin
MGudgin force-pushed the user/gudge/rename-codex-request branch 3 times, most recently from ce9f75e to 0163aa4 Compare May 28, 2026 04:59
The Rust struct `CodexRequest` in `src/wxc_common/src/models.rs` is
the validated, internal execution model that `Raw*` config-parser
structs are mapped to and that `ScriptRunner` implementations
consume. The name `Codex` is a historical holdover and no longer
reflects what the type represents.

`ExecutionRequest` matches the "request handed to a `ScriptRunner`
for execution" mental model and keeps the layered Policy → Config →
Runner vocabulary already used in the codebase clean:

| Layer                           | Type                |
|---------------------------------|---------------------|
| High-level user intent (TS SDK) | `SandboxPolicy`     |
| Wire format (TS → JSON)         | `ContainerConfig`   |
| Permissive parse (Rust)         | `Raw*` structs      |
| Validated internal form (Rust)  | `ExecutionRequest`  |

Closes #446

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@MGudgin
MGudgin force-pushed the user/gudge/rename-codex-request branch from 0163aa4 to 1170d35 Compare May 28, 2026 15:43
@MGudgin
MGudgin merged commit ad6ccbd into main May 28, 2026
20 checks passed
@MGudgin
MGudgin deleted the user/gudge/rename-codex-request branch May 28, 2026 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants