Closed
Conversation
Member
|
@copilot try again |
Copilot stopped work on behalf of
asklar due to an error
May 22, 2026 01:10
The CCA crashes on session init because the lsp tool created from lsp.json conflicts with the SDK session's built-in lsp tool (overridesBuiltInTool is not set). Removing lsp.json as a temporary workaround until github/copilot-agent-runtime#8532 is fixed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR currently removes the repository’s .github/lsp.json (LSP server configuration). This does not align with the stated PR goal of adding mxc-diagnostic-console.exe to the release binaries artifact.
Changes:
- Delete
.github/lsp.json(Rust/TypeScript LSP server configuration for the repo).
Show a summary per file
| File | Description |
|---|---|
| .github/lsp.json | Removed LSP server configuration file (repo tooling/config). |
Copilot's findings
Comments suppressed due to low confidence (1)
.github/lsp.json:1
- This PR deletes
.github/lsp.json, but the PR title/description is about addingmxc-diagnostic-console.exeto release binaries. If the deletion is intentional, the PR description should be updated and any replacement for LSP configuration should be added; otherwise, restore.github/lsp.json(and note.github/copilot-instructions.mdstill references it).
- Files reviewed: 1/1 changed files
- Comments generated: 0
Copilot
AI
changed the title
[WIP] Add mxc-diagnostic-console.exe to release binaries
Include diagnostic console in release binaries
May 22, 2026
Re-add LSP config now that the cloud agent's work is done. Tracked upstream fix in github/copilot-agent-runtime#8532. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
|
looks like we have a flakey |
bbonaby
added a commit
that referenced
this pull request
May 22, 2026
Bump SDK to 0.2.1 and include mxc-diagnostic-console in release artifacts Mirrors PR #377: adds mxc-diagnostic-console.exe to the Rust.Build.Job.yml signPattern (so it gets signed and copied into wxc-binaries-* artifacts and into the mxc-release-binaries.zip) and to EXPECTED_WINDOWS_BINARIES in the SDK integration test helper. Also bumps the npm SDK from 0.2.0 to 0.2.1. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
|
Not sure why this keeps failing in the end so went ahead and created: #382 which passed the PR pipeline and has been checked in. It does the same thing but also bumps SDK version to 0.2.1 so we can release. Thanks Alex for trying to get copilot to spin this up, I'll just close this one now that the works been checked in. Hope that's ok. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mxc-release-binariesdid not includemxc-diagnostic-console.exe, so users downloading release artifacts could not run the shared diagnostics console.Release packaging
mxc-diagnostic-console.exeto the Windows binary signing/copy pattern, so it is included in per-arch artifacts and the aggregated release zip.Package expectations