[LXC] Build fix for Linux#305
Merged
Merged
Conversation
huzaifa-d
marked this pull request as ready for review
May 14, 2026 21:56
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Fixes Linux build failures in the build.sh lint step by avoiding clippy over the full workspace (which includes Windows-only crates), and addresses a clippy warning in the Windows-specific logger path.
Changes:
- Scope
cargo clippyinbuild.shtolxc,lxc_common, andwxc_commoninstead of--workspace. - Add documentation in
build.shexplaining why workspace-wide clippy fails on Linux. - Refactor
diag_accumulateto avoid an early-return pattern that triggered clippy warnings in conditional compilation scenarios.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/wxc_common/src/logger.rs | Adjusts Windows-only diagnostic accumulation logic to avoid clippy warnings. |
| build.sh | Limits clippy to Linux-compatible crates and documents the rationale. |
Comment on lines
262
to
+263
| #[cfg(target_os = "windows")] | ||
| { | ||
| if self.diag_pipe.is_none() { | ||
| return; | ||
| } | ||
| if self.diag_pipe.is_some() { |
Contributor
Author
There was a problem hiding this comment.
Following project convention
…into feat/LXC-InstallBug
…into feat/LXC-InstallBug
bbonaby
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
build.shalways failed at the lint step on Linux becausecargo clippy --workspace --all-targetscompiled every crate in the workspace — including Windows-only ones whose dependencies don't exist on Linux.This PR scopes clippy to the three crates that
build.shactually targets:lxc,lxc_common, andwxc_common.It also fixes a pre-existing clippy warning in
logger.rswhere an earlyreturninside a#[cfg(windows)]block produced an unreachable-code warning when linted on Linux.📋 Issue Type
Microsoft Reviewers: Open in CodeFlow