Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for broken mssql-jdbc.properties location logic #2579

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

Jeffery-Wasty
Copy link
Contributor

The logic for finding the mssql-jdbc.properties file, used in Configurable Retry Logic was correct for test environments, and when building the driver manually, but not correct when using the driver as a jar or dependency. This fixes that issue by only removing the target/classes suffix if needed.

@Jeffery-Wasty Jeffery-Wasty modified the milestone: 12.10.0 Jan 9, 2025
@Jeffery-Wasty Jeffery-Wasty linked an issue Jan 9, 2025 that may be closed by this pull request
@Jeffery-Wasty Jeffery-Wasty self-assigned this Jan 9, 2025
@Jeffery-Wasty Jeffery-Wasty added the Under Review Used for pull requests under review label Jan 10, 2025
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 51.37%. Comparing base (5bb3353) to head (f902c81).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...crosoft/sqlserver/jdbc/ConfigurableRetryLogic.java 40.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2579      +/-   ##
============================================
+ Coverage     51.01%   51.37%   +0.36%     
- Complexity     3921     3973      +52     
============================================
  Files           147      147              
  Lines         33483    33671     +188     
  Branches       5609     5628      +19     
============================================
+ Hits          17081    17299     +218     
+ Misses        13991    13935      -56     
- Partials       2411     2437      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Under Review Used for pull requests under review
Projects
Status: Under Peer Review
Development

Successfully merging this pull request may close these issues.

Broken logic in ConfigurableRetryLogic
6 participants