Skip to content

[release-branch.go1.27] Retry Darwin tests on fresh agents - #2717

Closed
Quim Muntal (qmuntal) wants to merge 1 commit into
microsoft/release-branch.go1.27from
dev/qmuntal/darwin-retry-go1.27
Closed

Quim Muntal (qmuntal) wants to merge 1 commit into
microsoft/release-branch.go1.27from
dev/qmuntal/darwin-retry-go1.27

Conversation

@qmuntal

Copy link
Copy Markdown
Member

Summary

  • Retry failed Darwin test runs once on a fresh hosted agent, reusing the already-built toolchain.
  • Publish per-attempt diagnostics and test results.

Backport of #2616. This preserves the existing Go 1.27 Darwin/amd64 timeout scaling and adapts the retry plumbing to the servicing pipeline templates.

Validation

  • go test -mod=readonly -count=1 ./cmd/pipelineymlgen ./cmd/run-builder
  • go vet -mod=readonly ./cmd/run-builder
  • git diff --check

Hosted Azure DevOps validation is pending.

Backport of #2616. Retry failed Darwin test runs once on a fresh hosted
agent, reusing the already-built toolchain, and publish per-attempt
diagnostics and results.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
There may be pipelines that require an authorized user to comment /azp run to run.

@qmuntal
Quim Muntal (qmuntal) marked this pull request as ready for review November 11, 2026 13:23
@qmuntal
Quim Muntal (qmuntal) requested a review from a team as a code owner November 11, 2026 13:23
Copilot AI balanced review requested due to automatic review settings November 11, 2026 13:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The publish task lacks the targetPath and artifactName inputs needed to publish the staged toolchain, preventing a failed Darwin attempt from passing it to the fresh retry agent.

1 open issue
What changed in this PR

Backports fresh-agent Darwin test retries to the Go 1.27 servicing pipelines, reusing the built toolchain and preserving existing timeout scaling.

Changes:

  • Limits eligible Darwin builders to an initial test run and one conditional fresh-agent retry.
  • Extracts shared test steps with per-attempt results and diagnostic artifacts.
  • Adds regression tests for retry gating, command arguments, exit handling, and toolchain archiving.
File Description
eng/​pipeline/​steps/​run-builder-tests.yml Shares test execution and per-attempt result publishing.
eng/​pipeline/​stages/​run-stage.yml Adds toolchain snapshots and a conditional fresh-agent retry job.
eng/​pipeline/​stages/​builders-to-stages.yml Enables fresh-agent retries for eligible Darwin builders.
eng/​_util/​cmd/​pipelineymlgen/​run_stage_test.go Tests retry configuration, commands, and archive restoration.

Review effort: Balanced

Comment on lines +267 to +269
- task: ${{ iif(eq(variables['System.TeamProject'], 'public'), '', '1ES.') }}PublishPipelineArtifact@1
displayName: Publish toolchain for test retry
condition: and(succeeded(), ne(variables['TEST_BUILDER_SUCCESSFUL'], 'true'))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants