Implement json2junit #212
Implement json2junit #212
Conversation
Good call. It makes sense. Done 😺. This is the new API: func Convert(w io.Writer, r io.Reader) error
func ConvertFile(out, in string) error
type Converter struct {
// Has unexported fields.
}
func NewConverter(w io.Writer) *Converter
func (c *Converter) Close() error
func (c *Converter) Write(b []byte) (int, error) |
| @@ -0,0 +1,7 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <testsuites> | |||
| <testsuite name="cmd/go" tests="2" failures="0" skipped="0" time="0.011" timestamp="2025-02-07T14:43:16+01:00"> | |||
There was a problem hiding this comment.
It might be worth adding a tiny happy path test json that's easy for a person to read in full (without truncation by default) (maybe also easier to debug into). chatty.json is the smallest one, but it's still intentionally not short.
Here's one: 828f05c
| @@ -0,0 +1,100 @@ | |||
| {"Time":"2025-02-07T14:43:16.4746636+01:00","Action":"start","Package":"cmd/go"} | |||
| {"Time":"2025-02-07T14:43:16.4751944+01:00","Action":"run","Package":"cmd/go","Test":"TestScript"} | |||
There was a problem hiding this comment.
.jsonl will make VS Code's syntax checker happy, by the way. ("JSON Lines".)
|
|
||
| func (s junitTestSuite) testCase(name string) *junitTestCase { | ||
| for _, tc := range s.TestCases { | ||
| if tc.Name == name { |
There was a problem hiding this comment.
Hmm, it seems like testCase and suite are called in a decently tight loop, and I wonder if maps are actually still worth the trouble...
| return fmt.Errorf("no start entry for %v", entry.Package) | ||
| } | ||
| testCase := suite.testCase(entry.Test) | ||
| if testCase == nil { |
There was a problem hiding this comment.
Why no error if there's a duplicate test start, like the error for duplicate suite start?
Co-authored-by: Davis Goodin <[email protected]>
This PR implements a simpler converted from Go JSON output to JUnit XML files.
The implementation is less that 300 lines. I don't expect it to grow in the future, it is feature completetm. The remaining additions in this PR are just test files.
The alternatives are:
All in all, I think it worth having some tailored parser to cover our limited use-case.