Skip to content

[ms-go1.27-support] Detect ML-DSA external-mu capabilities - #109

Merged
George Adams (gdams) merged 1 commit into
ms-go1.27-supportfrom
dev/gdams/mldsa-external-mu-go1.27
Oct 28, 2026
Merged

George Adams (gdams) merged 1 commit into
ms-go1.27-supportfrom
dev/gdams/mldsa-external-mu-go1.27

Conversation

@gdams

@gdams George Adams (gdams) commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

Summary

Backport #108 (28e7a1e) onto ms-go1.27-support before updating the Microsoft Go 1.27 dependency.

  • Add the cached per-parameter SupportsMLDSAExternalMu probe for actual signing and verification support.
  • Keep ordinary native ML-DSA enabled on SymCrypt while exposing that external-mu is unavailable.
  • Retain capability-aware tests and benchmarks from the mainline fix.
  • Includes only the two ML-DSA source/test files; no unrelated mainline dependency or generated-code changes.

Microsoft Go integration PR microsoft/go#2663 is pinned to this backport commit (62cbf925545f), not the mainline commit. Merge this support-branch PR first. Go 1.26 has no ML-DSA integration and needs no matching update.

Validation

  • Targeted ML-DSA and capability tests pass against local OpenSSL.
  • Targeted ML-DSA/capability tests pass against the actual published Azure Linux 4 ARM64 SymCrypt image with cgo enabled and disabled.
  • Microsoft Go 1.27 integration was repinned to this backport and revalidated: full ML-DSA tests, dependency checks, and external-mu tests in cgo/non-cgo and CI FIPS modes all pass.
  • git diff --check passes.

Expose a cached per-parameter capability probe that exercises native external-mu signing and verification. SymCrypt supports ML-DSA but rejects external-mu, so callers must distinguish these capabilities before choosing fallback operations. Keep ordinary ML-DSA coverage active and gate only external-mu tests and benchmarks on the new capability.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
(cherry picked from commit 28e7a1e)
@gdams
George Adams (gdams) requested a review from a team as a code owner October 28, 2026 13:05
Copilot AI balanced review requested due to automatic review settings October 28, 2026 13:05
@gdams
George Adams (gdams) enabled auto-merge (squash) October 28, 2026 13:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Azure Linux 4 SymCrypt validation is still pending to confirm both cgo modes report external-mu as unsupported while ordinary ML-DSA remains functional on the support branch.

No open issues 🎉

What changed in this PR

Backports external-mu capability detection to ms-go1.27-support for Microsoft Go 1.27 integration, preserving ordinary ML-DSA support on providers such as SymCrypt.

Changes:

  • Adds cached, per-parameter SupportsMLDSAExternalMu probes that exercise signing and verification.
  • Adds capability-consistency tests and gates only external-mu tests and benchmarks.
  • Limits the backport to ML-DSA implementation and tests, without dependency or generated-code changes.
File Description
openssl/​mldsa.go Adds the external-mu capability API and cached operation probes.
openssl/​mldsa_test.go Tests capability consistency and makes external-mu coverage capability-aware.

Review effort: Balanced

@gdams
George Adams (gdams) merged commit 38f583a into ms-go1.27-support Oct 28, 2026
113 checks passed
@gdams
George Adams (gdams) deleted the dev/gdams/mldsa-external-mu-go1.27 branch October 28, 2026 13:21
@github-actions

Copy link
Copy Markdown
Contributor

Benchmark Results

✅ No significant regressions detected

✅ ubuntu-22.04-go1.26-cgo1-ossl3.0.13 · results
✅ ubuntu-22.04-go1.26-cgo1-ossl3.1.5 · results
✅ ubuntu-22.04-go1.26-cgo1-ossl3.2.1 · results
✅ ubuntu-22.04-go1.26-cgo1-ossl3.3.1 · results
✅ ubuntu-22.04-go1.26-cgo1-ossl3.4.0 · results
✅ ubuntu-22.04-go1.26-cgo1-ossl3.5.0 · results
✅ ubuntu-22.04-go1.27-cgo1-ossl3.0.13 · results
✅ ubuntu-22.04-go1.27-cgo1-ossl3.1.5 · results
✅ ubuntu-22.04-go1.27-cgo1-ossl3.2.1 · results
✅ ubuntu-22.04-go1.27-cgo1-ossl3.3.1 · results
✅ ubuntu-22.04-go1.27-cgo1-ossl3.4.0 · results
✅ ubuntu-22.04-go1.27-cgo1-ossl3.5.0 · results
✅ ubuntu-24.04-arm-go1.26-cgo1-ossl3.0.13 · results
✅ ubuntu-24.04-arm-go1.26-cgo1-ossl3.1.5 · results
✅ ubuntu-24.04-arm-go1.26-cgo1-ossl3.2.1 · results
✅ ubuntu-24.04-arm-go1.26-cgo1-ossl3.3.1 · results
✅ ubuntu-24.04-arm-go1.26-cgo1-ossl3.4.0 · results
✅ ubuntu-24.04-arm-go1.26-cgo1-ossl3.5.0 · results
✅ ubuntu-24.04-arm-go1.27-cgo1-ossl3.0.13 · results
✅ ubuntu-24.04-arm-go1.27-cgo1-ossl3.1.5 · results
✅ ubuntu-24.04-arm-go1.27-cgo1-ossl3.2.1 · results
✅ ubuntu-24.04-arm-go1.27-cgo1-ossl3.3.1 · results
✅ ubuntu-24.04-arm-go1.27-cgo1-ossl3.4.0 · results
✅ ubuntu-24.04-arm-go1.27-cgo1-ossl3.5.0 · results
✅ ubuntu-latest-go1.26-cgo1-azl3 · results
✅ ubuntu-latest-go1.27-cgo1-azl3 · results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants