Repository navigation
[ms-go1.27-support] Detect ML-DSA external-mu capabilities - #109
Conversation
Expose a cached per-parameter capability probe that exercises native external-mu signing and verification. SymCrypt supports ML-DSA but rejects external-mu, so callers must distinguish these capabilities before choosing fallback operations. Keep ordinary ML-DSA coverage active and gate only external-mu tests and benchmarks on the new capability. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> (cherry picked from commit 28e7a1e)
There was a problem hiding this comment.
🔵 Needs a closer look
Azure Linux 4 SymCrypt validation is still pending to confirm both cgo modes report external-mu as unsupported while ordinary ML-DSA remains functional on the support branch.
No open issues 🎉
What changed in this PR
Backports external-mu capability detection to ms-go1.27-support for Microsoft Go 1.27 integration, preserving ordinary ML-DSA support on providers such as SymCrypt.
Changes:
- Adds cached, per-parameter
SupportsMLDSAExternalMuprobes that exercise signing and verification. - Adds capability-consistency tests and gates only external-mu tests and benchmarks.
- Limits the backport to ML-DSA implementation and tests, without dependency or generated-code changes.
| File | Description |
|---|---|
openssl/mldsa.go |
Adds the external-mu capability API and cached operation probes. |
openssl/mldsa_test.go |
Tests capability consistency and makes external-mu coverage capability-aware. |
Review effort: Balanced
Benchmark Results✅ No significant regressions detected ✅ |
Summary
Backport #108 (28e7a1e) onto
ms-go1.27-supportbefore updating the Microsoft Go 1.27 dependency.SupportsMLDSAExternalMuprobe for actual signing and verification support.Microsoft Go integration PR microsoft/go#2663 is pinned to this backport commit (
62cbf925545f), not the mainline commit. Merge this support-branch PR first. Go 1.26 has no ML-DSA integration and needs no matching update.Validation
git diff --checkpasses.