Remove gsl/span dependency from C++ API. - #992
Closed
Scott McKay (skottmckay) wants to merge 1 commit into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the Microsoft GSL dependency from the public C++ wrapper while preserving model-list behavior.
Changes:
- Replaces
gsl::spanwith non-owningstd::vector<IModel*>. - Updates JavaScript native bindings and C++ tests.
- Removes GSL build dependencies and updates design documentation.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
sdk_v2/js/native/src/model.cc |
Adapts model wrapping to raw pointers. |
sdk_v2/js/native/src/catalog.cc |
Adapts catalog model wrapping. |
sdk_v2/cpp/vcpkg.json |
Removes ms-gsl. |
sdk_v2/cpp/test/sdk_api/catalog_test.cc |
Updates tests for the new collection type. |
sdk_v2/cpp/include/foundry_local/foundry_local_cpp.inline.h |
Implements the pointer-vector projection. |
sdk_v2/cpp/include/foundry_local/foundry_local_cpp.h |
Removes GSL and updates the public API. |
sdk_v2/cpp/docs/WrapperInterfacesDesign.md |
Documents non-owning standard-library collections. |
sdk_v2/cpp/CMakeLists.txt |
Removes GSL package and linkage requirements. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Collaborator
Author
|
going with #992 for consistency |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.