Skip to content

Preserve HTTP errors when loading JS models#908

Open
fallintoplace wants to merge 1 commit into
microsoft:mainfrom
fallintoplace:fix/js-model-load-http-errors
Open

Preserve HTTP errors when loading JS models#908
fallintoplace wants to merge 1 commit into
microsoft:mainfrom
fallintoplace:fix/js-model-load-http-errors

Conversation

@fallintoplace

Copy link
Copy Markdown

Summary

  • limit network error wrapping to failures thrown by fetch
  • preserve unsuccessful HTTP responses as server errors with the status code
  • add focused coverage for HTTP and transport failures

Validation

  • npm test -- --grep "ModelLoadManager external service errors"
  • npm run build
  • isolated TypeScript check for the changed source and test

Copilot AI review requested due to automatic review settings July 26, 2026 02:48
@vercel

vercel Bot commented Jul 26, 2026

Copy link
Copy Markdown

@fallintoplace is attempting to deploy a commit to the MSFT-AIP Team on Vercel.

A member of the Team first needs to authorize it.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Preserves HTTP failure details when loading JavaScript models through an external service.

Changes:

  • Limits network-error wrapping to rejected fetch calls.
  • Includes HTTP status codes in response errors.
  • Adds focused HTTP and transport failure tests.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
sdk/js/src/detail/modelLoadManager.ts Separates transport failures from unsuccessful HTTP responses.
sdk/js/test/detail/modelLoadManager.externalService.test.ts Covers HTTP 404 and rejected-fetch behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants