Preserve HTTP errors when loading JS models#908
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
|
@fallintoplace is attempting to deploy a commit to the MSFT-AIP Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
Pull request overview
Preserves HTTP failure details when loading JavaScript models through an external service.
Changes:
- Limits network-error wrapping to rejected
fetchcalls. - Includes HTTP status codes in response errors.
- Adds focused HTTP and transport failure tests.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
sdk/js/src/detail/modelLoadManager.ts |
Separates transport failures from unsuccessful HTTP responses. |
sdk/js/test/detail/modelLoadManager.externalService.test.ts |
Covers HTTP 404 and rejected-fetch behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fetchValidation
npm test -- --grep "ModelLoadManager external service errors"npm run build