Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(react-tree): introduces navigationMode property #33658

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

bsunderhus
Copy link
Contributor

@bsunderhus bsunderhus commented Jan 15, 2025

Previous Behavior

New Behavior

  1. Introduces navigationMode property
    • tree (default) - navigation as expected by tree WAI ARIA spec (+ actions interactions)
    • treegrid - navigation similar to treegrid WAI ARIA spec. pressing right arrow either opens the treeitem if it's a branch or goes from the treeitem (row) to its actions (cell). pressing up arrow goes to previous item, and down arrow to next item
  2. adds a story to showcase the new navigation mode.

Problems related:

  1. tabbing navigation between treeitem and actions is still valid (might be worth investigating tabster support to invalidate this navigation)

Related Issue(s)

  • Fixes #

@bsunderhus bsunderhus self-assigned this Jan 15, 2025
Copy link

github-actions bot commented Jan 15, 2025

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-components
react-components: entire library
1.164 MB
291.433 kB
1.165 MB
291.674 kB
1.136 kB
241 B
react-tree
FlatTree
145.565 kB
41.884 kB
147.367 kB
42.323 kB
1.802 kB
439 B
react-tree
PersonaFlatTree
146.251 kB
41.984 kB
148.055 kB
42.342 kB
1.804 kB
358 B
react-tree
PersonaTree
142.475 kB
40.818 kB
144.278 kB
41.181 kB
1.803 kB
363 B
react-tree
Tree
141.787 kB
40.712 kB
143.59 kB
41.153 kB
1.803 kB
441 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
69.236 kB
20.182 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
222.641 kB
64.474 kB
react-components
react-components: FluentProvider & webLightTheme
44.473 kB
14.597 kB
react-portal-compat
PortalCompatProvider
8.39 kB
2.64 kB
react-timepicker-compat
TimePicker
108.551 kB
36.094 kB
🤖 This report was generated against 556fc8e7b9a921cedbb07c2f0670dfabcf8ec0ed

Copy link

Pull request demo site: URL

@bsunderhus bsunderhus force-pushed the react-tree/feature--navigationMode=treegrid branch from c767926 to af1d442 Compare January 15, 2025 14:49
@bsunderhus bsunderhus marked this pull request as ready for review January 17, 2025 12:42
@bsunderhus bsunderhus requested a review from a team as a code owner January 17, 2025 12:42
ling1726
ling1726 previously approved these changes Jan 17, 2025
@ling1726 ling1726 dismissed their stale review January 17, 2025 14:15

behaviour does't match spec

@bsunderhus bsunderhus requested a review from ling1726 January 17, 2025 16:42
@bsunderhus bsunderhus requested a review from ling1726 January 17, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants