Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(accordion): correctly sets the expanded item in single mode #6620

Open
wants to merge 5 commits into
base: archives/fast-element-1
Choose a base branch
from

Conversation

YonatanKra
Copy link

Pull Request

📖 Description

Two use cases solved here:

  1. Focusing on a non expanded item and then triggering a change in the items causes the focused item to expand
  2. Adding items with expanded attribute are not respected and the first item was always expanded

🎫 Issues

Fixes #6618

👩‍💻 Reviewer Notes

📑 Test Plan

See the tests that were added

✅ Checklist

General

  • [ x ] I have included a change request file using $ yarn change
  • [ x ] I have added tests for my changes.
  • [ x ] I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • [ x ] I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

@janechu
Copy link
Collaborator

janechu commented Sep 11, 2024

Looks like we need to add a change file, can you run yarn change to generate one?

@YonatanKra
Copy link
Author

Looks like we need to add a change file, can you run yarn change to generate one?

Done @janechu

@janechu
Copy link
Collaborator

janechu commented Oct 2, 2024

Looks like we need to add a change file, can you run yarn change to generate one?

Done @janechu

I believe you might need to run it again, it should generate a change file for @microsoft/fast-foundation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants