Skip to content

fix - nested scrolling and full-row table selection for auto-approve preferences#256

Merged
jdneo merged 2 commits into
mainfrom
tori/approve-issue
Jun 2, 2026
Merged

fix - nested scrolling and full-row table selection for auto-approve preferences#256
jdneo merged 2 commits into
mainfrom
tori/approve-issue

Conversation

@xinyi-gong

Copy link
Copy Markdown
Member

Summary

  • Forward vertical mouse wheel events from auto-approve inner viewers to the parent preference scroller only after the inner viewer reaches its scroll boundary
  • Update auto-approve tables so the last column fills remaining table width, matching the custom instructions table behavior

Copilot AI review requested due to automatic review settings May 25, 2026 03:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the Auto-Approve preferences UI by making nested viewers scroll naturally inside a parent preference scroller, and by ensuring the “last” table column expands to fill remaining width (matching the existing Custom Instructions table behavior).

Changes:

  • Added a shared SWT utility to forward vertical mouse-wheel events to a parent ScrolledComposite when the nested viewer is at its scroll boundary.
  • Enabled vertical scrolling on the auto-approve Table/Tree viewers and applied the wheel-forwarding behavior.
  • Updated the auto-approve tables to resize the last column to fill remaining width on control resize.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/utils/SwtUtils.java Adds a helper to forward mouse-wheel scrolling from nested scrollables to a parent scroller at boundaries.
com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/preferences/TerminalAutoApproveSection.java Enables V_SCROLL, forwards wheel at boundaries, and makes the status column fill remaining table width.
com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/preferences/McpAutoApproveSection.java Enables V_SCROLL on the tree and forwards wheel at boundaries for better nested scrolling behavior.
com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/preferences/FileOperationAutoApproveSection.java Enables V_SCROLL, forwards wheel at boundaries, and makes the status column fill remaining table width.

@jdneo jdneo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdneo jdneo merged commit 4244f7b into main Jun 2, 2026
4 checks passed
@jdneo jdneo deleted the tori/approve-issue branch June 2, 2026 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants