Return error response on invalid json (#3673)

microsoft · Jan 23, 2018 · 40edcbf · 40edcbf
1 parent 63452f8
commit 40edcbf
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/Node/core/src/bots/ChatConnector.ts b/Node/core/src/bots/ChatConnector.ts
@@ -132,7 +132,15 @@ export class ChatConnector implements IConnector, IBotStorage {
                     requestData += chunk
                 });
                 req.on('end', () => {
-                    req.body = JSON.parse(requestData);
+                    try {
+                        req.body = JSON.parse(requestData);
+                    } catch (err) {
+                        logger.error('ChatConnector: receive - invalid request data received.');
+                        res.send(400);
+                        res.end();
+                        return;
+                    }
+
                     this.verifyBotFramework(req, res, next || defaultNext);
                 });
             }