Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bind postun #12577

Open
wants to merge 2 commits into
base: 3.0-dev
Choose a base branch
from
Open

fix bind postun #12577

wants to merge 2 commits into from

Conversation

tobiasb-ms
Copy link
Contributor

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

bind has a warning during uninstall:

# tdnf remove -y bind
<snip>

Removing: bind-9.20.5-1.azl3.x86_64
/var/tmp/rpm-tmp.o0lrpa: line 12: Vendor:: command not found
/var/tmp/rpm-tmp.o0lrpa: line 13: Distribution:: command not found
warning: %postun(bind-9.20.5-1.azl3.x86_64) scriptlet failed, exit status 127
package bind-9.20.5-1.azl3.x86_64: script warning in %postun

The issue is that we we're missing a new-line at the of the %postun scriptlet, which makes the Vendor: and Distribution: lines sneak into that script, which means bash tries to run them as programs. Interestingly, if you drop an executable file at, say, /usr/bin/Vendor:, this will run it. Fun.

This has been there for years and as it happens both the Vendor: and Distribution: lines were duplicates of the ones towards the top of the file so just deleting them and making sure we have the blank line fixes things.

Change Log
  • Remove spurious Vendor: and Distribution: lines.
Does this affect the toolchain?

NO

Associated issues
Test Methodology

@tobiasb-ms tobiasb-ms requested a review from a team as a code owner February 24, 2025 19:51
@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging 3.0-dev PRs Destined for AzureLinux 3.0 labels Feb 24, 2025
@@ -360,8 +360,7 @@ if [ $1 -gt 1 ]; then \
fi \
done \
fi
Vendor: Microsoft Corporation
Distribution: Azure Linux
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@@ -360,8 +360,7 @@ if [ $1 -gt 1 ]; then \
fi \
done \
fi
Vendor: Microsoft Corporation
Distribution: Azure Linux

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this (blank line) the fix that removes the warning ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0-dev PRs Destined for AzureLinux 3.0 Packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants