Upgrade rust to 1.85.0 #11443
Open
Upgrade rust to 1.85.0 #11443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KavyaSree2610
force-pushed
the
kkaitepalli/upgrade-rust-2.0
branch
from
703b56e to
700c956
Compare
jslobodzian
requested changes
Mar 5, 2025
| @@ -114,6 +118,7 @@ export CXXFLAGS="`echo " %{build_cxxflags} " | sed 's/ -g//'`" | |||
| sh ./configure \ | |||
There was a problem hiding this comment.
in the BuildRequires: above can we take an explicit dependency on the libz and in the vendor tarball generation for this can we explicitly remove any vendored source for zlib. We want to make sure that rust takes a dependency on the system zlib and not the internally vendored one. I believe this is already working implicitly, goal is to make it explicit
Bug 44559508: [2.0][3.0] [Rust] Remove vendored system libs from uploaded source tarball
|
@jslobodzian @KavyaSree2610 is there anything I can do to help move this forward? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
Change Log
Does this affect the toolchain?
NO
Associated issues
Links to CVEs
Test Methodology