Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade rust to 1.85.0 #11295

Open
wants to merge 62 commits into
base: 3.0-dev
Choose a base branch
from

Conversation

KavyaSree2610
Copy link
Contributor

@KavyaSree2610 KavyaSree2610 commented Dec 3, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?

  • Upgrade rust to 1.85.0
Change Log
  • Upgrade to 1.85.0
  • Drop unnecessary patches in rust
  • Remove expand-yaml-anchors tool in %check
  • Remove rust-demangler tool
  • Run tests as non root user in rust package
  • Skip some failing ci ptests
  • Build all packages which are dependent on rust
Does this affect the toolchain?

NO

Associated issues
Links to CVEs
Test Methodology

@KavyaSree2610 KavyaSree2610 force-pushed the kkaitepalli/upgrade-rust branch from f1ac25a to c7fb2c2 Compare December 13, 2024 06:05
@KavyaSree2610 KavyaSree2610 marked this pull request as ready for review December 19, 2024 06:53
@KavyaSree2610 KavyaSree2610 requested a review from a team as a code owner December 19, 2024 06:53
@KavyaSree2610 KavyaSree2610 added the 3.0-dev PRs Destined for AzureLinux 3.0 label Dec 19, 2024
Copy link
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please skip the failing tests, so that the pipeline is green.
Let's add a link where we skip to the FreeBSD forum to clarify on why are we even skiping :)

@KavyaSree2610 KavyaSree2610 requested a review from mfrw January 8, 2025 05:20
@KavyaSree2610 KavyaSree2610 requested a review from mfrw March 27, 2025 05:34
@microsoft-github-policy-service microsoft-github-policy-service bot added the specs-extended PR to fix SPECS-EXTENDED label Apr 1, 2025
@ms-mahuber
Copy link
Contributor

As the PR progresses, can we please post up to date pipeline links for all affected packages, showing build and package tests to behave according to our findings?

@KavyaSree2610
Copy link
Contributor Author

In retrospect, we should get to the bottom of why these patches removing tests are required before proceeding.

done with the investigation of the tests

@Camelron Camelron self-requested a review April 9, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0-dev PRs Destined for AzureLinux 3.0 Packaging specs-extended PR to fix SPECS-EXTENDED
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants