Add support for workspace v2 endpoints #702
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rigidit
changed the title
…nly when not live
rigidit
changed the title
rigidit
changed the title
katymccl
reviewed
Dec 11, 2025
katymccl
reviewed
Dec 11, 2025
kikomiss
reviewed
Dec 11, 2025
| WorkspaceName=(?P<workspace_name>[^\s;]+); | ||
| ApiKey=(?P<api_key>[^\s;]+); | ||
| QuantumEndpoint=(?P<quantum_endpoint>https://(?P<location>[^\s\.]+).quantum(?:-test)?.azure.com/); | ||
| QuantumEndpoint=(?P<quantum_endpoint>https://(?P<location>[^\s\.]+?)(?:-v2)?.quantum(?:-test)?.azure.com/); |
Collaborator
There was a problem hiding this comment.
Since part of the reason to start discovering endpoints was to stop hardcoding them in the codebase. I think to that end, we could just verify that the overall URL structure is correct without hardcoding quantum,v2,azure.com in it. I understand that here we verify the connection string, but I don't know if we're gaining much by hardcoding the URL again here.
Author
There was a problem hiding this comment.
I think it's more about security: we are validating string coming from user environment which is used to generate a URL and fail fast if invalid data is detected
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 702 in repo microsoft/azure-quantum-python |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For workspace initialization from connection string, regex is updated to handle both v1 and v2 workspaces.
For non connection strings, if user provided resource id or params to build the resource id, we call ARM to fetch the workspace and get location and endpoint information. In case there is not enough params to build resource id, but workspace name is provided, we try to query ARG.