Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

message registry buffer size limit #5582 #5603

Merged
merged 18 commits into from
Feb 21, 2025
Merged

Conversation

rysweet
Copy link
Collaborator

@rysweet rysweet commented Feb 18, 2025

Why are these changes needed?

helps ensure that we don't buffer messages that are too large

Related issue number

Closes #5582

Checks

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 0% with 103 lines in your changes missing coverage. Please review.

Project coverage is 64.01%. Comparing base (2f43005) to head (72a24b2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...eway.Grpc/Services/Orleans/MessageRegistryQueue.cs 0.00% 68 Missing and 11 partials ⚠️
...eway.Grpc/Services/Orleans/MessageRegistryGrain.cs 0.00% 24 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5603       +/-   ##
===========================================
- Coverage   75.41%   64.01%   -11.41%     
===========================================
  Files         171      131       -40     
  Lines       10467     4863     -5604     
  Branches        0      242      +242     
===========================================
- Hits         7894     3113     -4781     
+ Misses       2573     1561     -1012     
- Partials        0      189      +189     
Flag Coverage Δ
unittests 64.01% <0.00%> (-11.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jackgerrits jackgerrits requested a review from bassmang February 19, 2025 18:57
@rysweet rysweet merged commit 3a239c5 into main Feb 21, 2025
51 of 55 checks passed
@rysweet rysweet deleted the rysweet-buffer-size-limit-5582 branch February 21, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MessageRegistry should not buffer messages over a certain size or grow beyond a certain size
2 participants