feat: select errors that will be caught when raised within a tool #5488
Conversation
| @@ -37,6 +37,9 @@ def description(self) -> str: ... | |||
| @property | |||
| def schema(self) -> ToolSchema: ... | |||
|
|
|||
| @property | |||
| def return_errors(self) -> tuple[type[Exception], ...] | type[Exception]: ... | |||
There was a problem hiding this comment.
Let's rename it return_error_types? This makes it align with the return_type property that already exists.
Let's also add API doc comment to each field of Tool and BaseTool as a good Samaritan 😄
There was a problem hiding this comment.
Let's also add API doc comment to each field of Tool and BaseTool as a good Samaritan
Not sure what you mean by this. Do you want me to add docstrings to every function in Tool/BaseTool?
|
I think there was some confusion on the Issue regarding what this feature should do. Do we want to keep adding the error types to the Tool or is there now a preference to add it to the agent? Former has the advantage that you can deal differently with each tool, latter allows you to only define it once and it is applied automatically for every tool. |
Conversation starter to agree on the implementation. When we are aligned, I'll add tests.
Why are these changes needed?
Not every tool error should be returned to the agent. This change allows to cherry-pick which exceptions we want to share with the agent.
Related issue number
Closes: #5274
Checks