Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance AzureAIChatCompletionClient validation and add unit tests #5417

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

ekzhu
Copy link
Collaborator

@ekzhu ekzhu commented Feb 7, 2025

Resolves #5414

@ekzhu ekzhu enabled auto-merge (squash) February 7, 2025 05:05
@ekzhu ekzhu requested a review from lspinheiro February 7, 2025 05:06
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.12%. Comparing base (af5dcc7) to head (47b20d9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5417      +/-   ##
==========================================
+ Coverage   78.08%   78.12%   +0.04%     
==========================================
  Files         158      158              
  Lines        9576     9579       +3     
==========================================
+ Hits         7477     7484       +7     
+ Misses       2099     2095       -4     
Flag Coverage Δ
unittests 78.12% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ekzhu ekzhu merged commit 901ab12 into main Feb 7, 2025
64 checks passed
@ekzhu ekzhu deleted the ekzhu-validate-azure-ai branch February 7, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when closing AzureAIChatCompletionClient upon a validation error
2 participants