Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependencies to work with protobuf 5 #5195

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

MohMaz
Copy link
Contributor

@MohMaz MohMaz commented Jan 25, 2025

Why are these changes needed?

Conflicting version with some other dependencies (e.g. chainlit for UI development).

  • Tested on platform darwin, python 3.12.7-final-0 and aside from the tests, the distributed group chat sample works fine with the regenerated protos.
  • Seems dotnet was using a different version, skipping that for this PR
  • For UI development, devs should be able to install the repo as uv sync --extras dev and they will have chainlit installed as well

Related issue number

Closes #5074

Checks

@MohMaz MohMaz added the dependencies Pull requests that update a dependency file label Jan 25, 2025
Copy link

codecov bot commented Jan 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.90%. Comparing base (225eb9d) to head (d0ebd24).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5195      +/-   ##
==========================================
+ Coverage   70.45%   73.90%   +3.45%     
==========================================
  Files         179      116      -63     
  Lines       11588     7101    -4487     
==========================================
- Hits         8164     5248    -2916     
+ Misses       3424     1853    -1571     
Flag Coverage Δ
unittests 73.90% <ø> (+3.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MohMaz MohMaz requested review from jackgerrits and ekzhu January 25, 2025 08:37
@MohMaz MohMaz marked this pull request as ready for review January 25, 2025 08:37
Copy link
Contributor

@raimondasl raimondasl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@MohMaz MohMaz force-pushed the feat-update-to-protobuf-5 branch from 2b15f13 to 4ab9c9e Compare January 29, 2025 05:33
Signed-off-by: Mohammad Mazraeh <[email protected]>
@ekzhu ekzhu merged commit 2f1684b into microsoft:main Jan 29, 2025
65 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Protobuf 5+
3 participants