Remove ModelContextProtocol.AspNetCore package version#15654
Merged
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15654Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15654" |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes repository references to the ModelContextProtocol.AspNetCore NuGet package (and its corresponding signing entry), aligning the repo’s dependency metadata and documentation with current usage.
Changes:
- Removed the central package version entry for
ModelContextProtocol.AspNetCorefromDirectory.Packages.props. - Removed
ModelContextProtocol.AspNetCore.dllfrom the third-party signing list ineng/Signing.props. - Updated dependency-update guidance to no longer treat
ModelContextProtocol.AspNetCoreas part of the “ModelContextProtocol” package family.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/Signing.props | Drops signing configuration for ModelContextProtocol.AspNetCore.dll. |
| Directory.Packages.props | Removes the unused central version declaration for ModelContextProtocol.AspNetCore. |
| .github/skills/dependency-update/SKILL.md | Updates docs to reflect the package family change (no longer includes AspNetCore). |
Contributor
|
🎬 CLI E2E Test Recordings — 52 recordings uploaded (commit View recordings
📹 Recordings uploaded automatically from CI run #23665798266 |
JamesNK
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.