-
Notifications
You must be signed in to change notification settings - Fork 851
VS Code extension: Auto-restore on workspace open and config change #15546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
adamint
wants to merge
7
commits into
microsoft:main
Choose a base branch
from
adamint:dev/adamint/run-aspire-restore-branch-switch-workspace-open
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+332
−15
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
7965cb1
update playground aspire configs
adamint 39061ab
Implement automatic package restore
adamint 2e0c535
Address PR review comments: fix activate() early return, queue pendin…
adamint 9b0f6e8
Update extension/package.nls.json
adamint 8379bc4
Address PR review feedback: fix bugs, add restore command and failure…
adamint 8a23f34
Fix progress counter bugs in auto-restore
adamint e967e8d
Improve AspirePackageRestoreProvider robustness
adamint File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clicking the error status bar doesn't clear the error state.
The command runs
sendAspireCommandToAspireTerminal('restore'), which executes in the integrated terminal — completely separate fromAspirePackageRestoreProvider's internal state. Even if the manual terminal restore succeeds,_failedDirsis never cleared, so the error icon persists indefinitely. Only a file content change that triggers a successful automatic restore clears it.Consider either:
_failedDirsand re-trigger_restoreAll(), orAspirePackageRestoreProviderinstead of the terminal command.