-
Notifications
You must be signed in to change notification settings - Fork 876
Fix WithReference to only use IResourceWithEndpoints #14254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Falco20019
wants to merge
10
commits into
microsoft:main
Choose a base branch
from
Falco20019:patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+214
−1
Open
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
101c9e8
Fix WithReference to only use IResourceWithEndpoints
Falco20019 190a08b
Also ally to other variant
Falco20019 00e8642
Keep original ones
Falco20019 ef67ec8
Fix typo
Falco20019 7e90218
Rename to avoid issues and add tests
Falco20019 3f8e370
Only add ReferenceEnvironmentInjectionFlags.ServiceDiscovery on IReso…
Falco20019 ec595f0
Merge branch 'main' into patch-1
Falco20019 25934a6
Address review comments
Falco20019 f02b31a
Merge branch 'main' into patch-1
Falco20019 541b3b3
Try fix tests
Falco20019 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.