ci: add demo as part of ci so that the demos stay up to date and functional#3305
ci: add demo as part of ci so that the demos stay up to date and functional#3305prayagupa wants to merge 4 commits into
Conversation
PR Review Summary
Verdict: AI review comments are untrusted advisory output. The summary reports workflow-generated completion status only, not model-authored pass/fail claims. |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files
|
🤖 AI Agent: code-reviewer — View details
TL;DR: 0 blockers, 1 warning. The CI addition is functional but has a minor supply-chain safety concern.
Action items:
Warnings: fine as follow-up PRs. |
🤖 AI Agent: breaking-change-detector — API Compatibility
API CompatibilityNo breaking changes detected. |
🤖 AI Agent: test-generator — View details
Test coverage looks good. No gaps identified. |
🤖 AI Agent: docs-sync-checker — Docs Sync
Docs Sync
|
🤖 AI Agent: security-scanner — View details
No security issues found. |
3680fa9 to
bd41d3c
Compare
imran-siddique
left a comment
There was a problem hiding this comment.
Gating, pinning, and permissions are right, and paths-filter keeps this from running on every PR. Cache the Ollama binary and the pulled model keyed on OLLAMA_VERSION plus model to cut the per-run ~2GB download and network flakiness, and confirm the demo asserts on governance decisions rather than raw model output so a nondeterministic response cannot flake the gate.
|
@imran-siddique thank you for review. I intentionally did not to assert on demo code, but wanted to make sure they are functional. I have separate PR for end-to-end tests against local Open weight model: https://github.com/microsoft/agent-governance-toolkit/pull/3345/changes |
…tional Signed-off-by: Prayag Upadhyay <prayag.upd@gmail.com>
Signed-off-by: prayagupa <prayag.upd@gmail.com>
Address review feedback on the Demos workflow, aligning it with the tests/e2e_python e2e-python.yml workflow on feat/python-governance-e2e: - Replace `curl ... install.sh | sh` with a pinned, checksum-verified ollama-linux-amd64.tgz release download (v0.5.7 sha256). - Pin pip to 24.3.1, matching the other repo workflows. - Verify the pulled llama3.2:3b manifest digest against a pinned value so a tampered or drifted model fails the demo gate. - Cache the Ollama model (OLLAMA_MODELS keyed on version + digest) and enable pip caching, mirroring the e2e workflow. Signed-off-by: Prayag Upadhyay <prayag.upd@gmail.com>
The Demos CI workflow pulls llama3.1; update the README's no-API-key example to match so the documented model matches what CI exercises. Signed-off-by: Prayag Upadhyay <prayag.upd@gmail.com>
Description
Add a
DemosCI workflow that runs the AGT demos on every push and pull request, so the runnable demos stay functional and never drift from the codebase. The LLM-driven demo is exercised against a small open-source model (Meta Llama 3.2 3B) served locally by Ollama — no paid API keys or secrets required.Type of Change
Package(s) Affected
Checklist
Attribution & Prior Art
Prior art / related projects (if any):
AI Assistance
If AI tools materially shaped this change, briefly note what was used:
IP, Patents, and Licensing
Related Issues