Skip to content

fix(opencode): preserve audit chain verification across rollover eviction#3250

Draft
Peldan wants to merge 2 commits into
microsoft:mainfrom
Peldan:fix/opencode-audit-rollover
Draft

fix(opencode): preserve audit chain verification across rollover eviction#3250
Peldan wants to merge 2 commits into
microsoft:mainfrom
Peldan:fix/opencode-audit-rollover

Conversation

@Peldan

@Peldan Peldan commented Jul 3, 2026

Copy link
Copy Markdown

Description

The OpenCode adapter's audit log truncates to MAX_ENTRIES via .slice(-MAX_ENTRIES) on every append. That drops the GENESIS-anchored head, but verifyAuditEntries requires entries[0].previousHash === GENESIS_HASH, so once the log rolls over verification fails permanently. Because appends verify first and governance fails closed (denyOnPolicyError), every subsequent tool and prompt decision is then denied — the plugin bricks after MAX_ENTRIES entries.

Port the seam-hash re-anchoring already applied to the Go/Rust/TypeScript implementations in #1838 (which did not touch the OpenCode adapter): on eviction, retain the last evicted entry's hash as a seam and re-anchor the surviving chain to it in verifyAuditEntries. The seam is persisted in a backward-compatible way — logs that never roll over stay bare arrays; rolled-over logs use { seamHash, entries }; and an already-truncated legacy bare array is recovered by adopting its head's previousHash as the seam. Adds tests covering rollover, legacy recovery, format stability, and that content tampering is still detected.

Affected package: agent-governance-opencode (@microsoft/agent-governance-opencode).

Type of Change

  • Bug fix (non-breaking change that fixes an issue)

Package(s) Affected

  • agent-governance

Checklist

  • I have added tests that prove my fix/feature works

AI Assistance

  • I can explain every meaningful change in this PR: what it does, why, and what tradeoffs were considered
  • I have run tests and verification appropriate for this change
  • No part of this PR was autonomously submitted by an AI agent without my review
  • I have not used AI to generate review comments on others' PRs

If AI tools materially shaped this change, briefly note what was used:
AI assistance was used to confirm the bug with a standalone reproduction (a post-truncation appendAuditEntry throws failed hash-chain verification), draft the fix, and clarify the PR description. All changes reviewed and owned by me.

IP, Patents, and Licensing

  • This contribution does not implement patent-pending or patent-encumbered techniques
  • This contribution does not require an NDA or licensing agreement to understand or use
  • Any AI tools used have terms compatible with the MIT License

Related Issues

Related: #1838

…tion

The OpenCode adapter's audit log truncates to MAX_ENTRIES via
.slice(-MAX_ENTRIES) on every append. That drops the GENESIS-anchored head,
but verifyAuditEntries requires entries[0].previousHash === GENESIS_HASH, so
once the log rolls over verification fails permanently. Because appends
verify first and governance fails closed (denyOnPolicyError), every
subsequent tool and prompt decision is then denied — the plugin bricks after
MAX_ENTRIES entries.

Port the seam-hash re-anchoring already applied to the Go/Rust/TypeScript
implementations in microsoft#1838 (which did not touch the OpenCode adapter): on
eviction, retain the last evicted entry's hash as a seam and re-anchor the
surviving chain to it in verifyAuditEntries. The seam is persisted in a
backward-compatible way — logs that never roll over stay bare arrays; rolled
-over logs use { seamHash, entries }; and an already-truncated legacy bare
array is recovered by adopting its head's previousHash as the seam. Adds
tests covering rollover, legacy recovery, format stability, and that
content tampering is still detected.

Related: microsoft#1838
Signed-off-by: arvidpeldan <peldans@gmail.com>
@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

PR Review Summary

Check Status Details
🔍 Code Review ⚠️ Missing No current-run comment
🛡️ Security Scan ⚠️ Missing No current-run comment
🔄 Breaking Changes ⚠️ Missing No current-run comment
📝 Docs Sync ⚠️ Missing No current-run comment
🧪 Test Coverage ⚠️ Missing No current-run comment

Verdict: ⚠️ AI review incomplete; ready for human review

AI review comments are untrusted advisory output. The summary reports workflow-generated completion status only, not model-authored pass/fail claims.

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

Welcome to the Agent Governance Toolkit! Thanks for your first pull request.
Please ensure tests pass, code follows style (ruff check), and you have signed the CLA.
See our Contributing Guide.

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown
🤖 AI Agent: contributor-guide — View details

AI-generated review output. Treat it as untrusted analysis and verify before acting.

Welcome, and thank you for your contribution!

Your detailed explanation and thorough test coverage are impressive. Great job addressing backward compatibility and ensuring robust verification logic.

Before merging, please:

  1. Confirm that all new tests pass in the CI pipeline.
  2. Ensure the updated audit log format is documented for users in the relevant README or documentation.

For guidance, refer to CONTRIBUTING.md.

@github-actions github-actions Bot added the size/M Medium PR (< 200 lines) label Jul 3, 2026
@microsoft-github-policy-service

Copy link
Copy Markdown

@Peldan please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

  1. Definitions.
    “Code” means the computer software code, whether in human-readable or machine-executable form,
    that is delivered by You to Microsoft under this Agreement.
    “Project” means any of the projects owned or managed by Microsoft and offered under a license
    approved by the Open Source Initiative (www.opensource.org).
    “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
    Project, including but not limited to communication on electronic mailing lists, source code control
    systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
    discussing and improving that Project, but excluding communication that is conspicuously marked or
    otherwise designated in writing by You as “Not a Submission.”
    “Submission” means the Code and any other copyrightable material Submitted by You, including any
    associated comments and documentation.
  2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
    Project. This Agreement covers any and all Submissions that You, now or in the future (except as
    described in Section 4 below), Submit to any Project.
  3. Originality of Work. You represent that each of Your Submissions is entirely Your original work.
    Should You wish to Submit materials that are not Your original work, You may Submit them separately
    to the Project if You (a) retain all copyright and license information that was in the materials as You
    received them, (b) in the description accompanying Your Submission, include the phrase “Submission
    containing materials of a third party:” followed by the names of the third party and any licenses or other
    restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
    guidelines concerning Submissions.
  4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
    for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
    Submission is made in the course of Your work for an employer or Your employer has intellectual
    property rights in Your Submission by contract or applicable law, You must secure permission from Your
    employer to make the Submission before signing this Agreement. In that case, the term “You” in this
    Agreement will refer to You and the employer collectively. If You change employers in the future and
    desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
    and secure permission from the new employer before Submitting those Submissions.
  5. Licenses.
  • Copyright License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
    Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
    the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
    parties.
  • Patent License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
    Your patent claims that are necessarily infringed by the Submission or the combination of the
    Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
    import or otherwise dispose of the Submission alone or with the Project.
  • Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
    No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
    granted by implication, exhaustion, estoppel or otherwise.
  1. Representations and Warranties. You represent that You are legally entitled to grant the above
    licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
    have disclosed under Section 3). You represent that You have secured permission from Your employer to
    make the Submission in cases where Your Submission is made in the course of Your work for Your
    employer or Your employer has intellectual property rights in Your Submission by contract or applicable
    law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
    have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
    You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
    REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
    EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
    PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
    NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
  2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
    You later become aware that would make Your representations in this Agreement inaccurate in any
    respect.
  3. Information about Submissions. You agree that contributions to Projects and information about
    contributions may be maintained indefinitely and disclosed publicly, including Your name and other
    information that You submit with Your Submission.
  4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
    the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
    Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
    exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
    defenses of lack of personal jurisdiction and forum non-conveniens.
  5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
    supersedes any and all prior agreements, understandings or communications, written or oral, between
    the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Medium PR (< 200 lines)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant