fix: use configured timeoutSeconds in DockerSandboxProvider.executeCode

[jlaportebot]

Summary

The executeCode method in DockerSandboxProvider was using a hardcoded 60,000ms timeout instead of respecting the timeoutSeconds value from SandboxConfig. This caused custom timeouts to be ignored, potentially allowing unbounded execution.

Changes

• Store the SandboxConfig alongside the containerId in the containers map
• Use config.timeoutSeconds * 1000 as the timeout for execFile calls in executeCode
• Updated destroySession to destructure containerId from the new map value

Test Plan

• All existing tests pass (560 tests)
• TypeScript build succeeds
• Lint passes

Fixes #3118

[github-actions]

🤖 AI Agent: breaking-change-detector — API Compatibility

AI-generated review output. Treat it as untrusted analysis and verify before acting.

API Compatibility

Severity	Change	Impact
High	The type of the containers map in DockerSandboxProvider was changed from Map<string, string> to Map<string, { containerId: string; config: SandboxConfig }>	This is a breaking change for any code that directly accesses or manipulates the containers map, as the value type has changed.
High	The destroySession method now destructures containerId from the new map value structure	Any external code relying on the previous behavior of destroySession may break if it interacts with the containers map directly.

[github-actions]

🤖 AI Agent: security-scanner — Security Review

AI-generated review output. Treat it as untrusted analysis and verify before acting.

Security Review

Severity	Finding	Fix
High	The timeoutSeconds value from SandboxConfig is directly used to calculate the timeout for execFile calls without validation or sanitization. This could allow an attacker to set an excessively high or low timeout, potentially enabling denial-of-service or bypassing execution limits.	Validate and enforce reasonable bounds on timeoutSeconds before using it to calculate timeoutMs.
High	Code execution relies on dynamically constructed arguments for execFile, including user-provided code. This could lead to command injection if the code is not properly sanitized.	Ensure strict validation and sanitization of the code parameter to prevent command injection vulnerabilities.
High	The execFile function is used to execute Docker commands, which could potentially allow sandbox escape or privilege escalation if the Docker container is misconfigured or compromised.	Review Docker container configuration to ensure proper isolation and security measures are in place. Consider using additional sandboxing mechanisms.

[github-actions]

🤖 AI Agent: docs-sync-checker — Docs Sync

AI-generated review output. Treat it as untrusted analysis and verify before acting.

Docs Sync

• DockerSandboxProvider.executeCode in agent-governance-typescript/src/sandbox.ts -- missing docstring for the updated behavior regarding the use of config.timeoutSeconds for the timeout.
• README.md -- verify if the usage of timeoutSeconds in DockerSandboxProvider is documented.
• CHANGELOG.md -- missing entry for the behavioral change in DockerSandboxProvider.executeCode to respect timeoutSeconds from SandboxConfig.

[github-actions]

🤖 AI Agent: test-generator — `agent-governance-typescript/src/sandbox.ts`

AI-generated review output. Treat it as untrusted analysis and verify before acting.

agent-governance-typescript/src/sandbox.ts

• test_executeCode_respects_timeoutSeconds -- Verify that executeCode uses the timeoutSeconds value from SandboxConfig for the execFile timeout.
• test_executeCode_throws_error_for_missing_session -- Ensure executeCode throws an error when the session ID is not found in the containers map.
• test_destroySession_handles_missing_session_gracefully -- Confirm destroySession does not throw an error when the session ID is not found in the containers map.

[github-actions]

🤖 AI Agent: code-reviewer — View details

AI-generated review output. Treat it as untrusted analysis and verify before acting.

TL;DR: 0 blockers, 1 warning. The PR improves timeout handling but lacks test coverage for the new behavior.

#	Sev	Issue	Where
1	Warn	No new tests for timeoutSeconds behavior	agent-governance-typescript/src/sandbox.ts

Action items:

• None.

Warnings:

#	Issue	Where	Resolution
1	No new tests for timeoutSeconds behavior	agent-governance-typescript/src/sandbox.ts	Fine as follow-up PR.

[github-actions]

PR Review Summary

Check	Status	Details
🔍 Code Review	⚠️ Missing	No current-run comment
🛡️ Security Scan	⚠️ Missing	No current-run comment
🔄 Breaking Changes	⚠️ Missing	No current-run comment
📝 Docs Sync	⚠️ Missing	No current-run comment
🧪 Test Coverage	⚠️ Missing	No current-run comment

Verdict: ⚠️ AI review incomplete; ready for human review

AI review comments are untrusted advisory output. The summary reports workflow-generated completion status only, not model-authored pass/fail claims.

[github-actions]

🔴 Contributor Check: HIGH

Check	Result
Profile	HIGH
Credential	LOW
Overall	HIGH

Automated check by AGT Contributor Check.

[liamcrumm]

Please fix failing checks, also would prefer if you club #3198, #3201, and #3203 into one PR if possible.