-
Notifications
You must be signed in to change notification settings - Fork 643
Python: feat(devui): enable manual workflow triggers with comprehensive type support #1693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ChrisMcKee1
wants to merge
6
commits into
microsoft:main
Choose a base branch
from
ChrisMcKee1:devui-manual-trigger
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
3dd8f23
feat(devui): enable manual workflow triggers with comprehensive type …
ChrisMcKee1 c72eedd
chore: update Python dependencies to match main branch
ChrisMcKee1 98839d2
style(devui): apply ruff auto-fixes for code formatting
ChrisMcKee1 c8211c7
refactor(devui): address code review feedback
ChrisMcKee1 9fee459
test(devui): add unit tests for None and Optional type schema generation
ChrisMcKee1 875a636
fix: update microsoft-agents dependencies to v0.5.0 to avoid packagin…
ChrisMcKee1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
90 changes: 45 additions & 45 deletions
90
...amework_devui/ui/assets/index-D_Y1oSGu.js → ...amework_devui/ui/assets/index-87VYqhCr.js
Large diffs are not rendered by default.
Oops, something went wrong.
1 change: 0 additions & 1 deletion
1
python/packages/devui/agent_framework_devui/ui/assets/index-CE4pGoXh.css
This file was deleted.
Oops, something went wrong.
1 change: 1 addition & 0 deletions
1
python/packages/devui/agent_framework_devui/ui/assets/index-Ode5s4DB.css
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks,
Should we consider adding a decent but minimal test for test for non_type ? probably in ``test_schema_generation.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! Added test_none_type_schema_generation() and test_optional_type_schema_generation() in test_schema_generation.py. Both tests pass.