Skip to content

Conversation

@ghost1372
Copy link
Contributor

ItemTemplates.xaml uses an 8px corner radius, while the GridViewItem itself uses 4px. This difference is visible when hovering over the item.

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Before:
image

After:
image

Copy link
Contributor

@Zakariathr22 Zakariathr22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ghost1372, this is actually a really good idea! We should consider applying it to items in:

  • Recently visited
  • Favorites
  • SectionPage
  • SearchResultsPage

@ghost1372
Copy link
Contributor Author

Thank you @Zakariathr22
Good catch! I missed applying it earlier, it’s all fixed now.

@Jay-o-Way
Copy link
Contributor

Why not use the CornerRadius property directly? With Static resource for Overlay.

@ghost1372
Copy link
Contributor Author

Why not use the CornerRadius property directly? With Static resource for Overlay.

Since it's been 2 weeks, if I remember correctly I tried to set CornerRadius in GridViewItem, but it didn't work and I used lightweight styling.

@niels9001
Copy link
Collaborator

/azp run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants