Skip to content

When a tool fails, attempt to show lines that contain error information #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

When a tool fails, attempt to show lines that contain error information #152

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a4ca0a7
Print all lines, not just error lines, when a tool hits an error
JesseCol Dec 2, 2025
43f9fd8
Merge branch 'main' into jessecol/show-error-lines
nmetulev Dec 2, 2025
3a544e6
Merge branch 'main' into jessecol/show-error-lines
JesseCol Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/winapp-CLI/WinApp.Cli/Services/BuildToolsService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,22 @@ public async Task<FileInfo> EnsureBuildToolAvailableAsync(string toolName, Cance

if (p.ExitCode != 0)
{
// Print lines from both stdout and stderr when not in verbose mode so the user can determine
// what went wrong.
// In verbose mode, all output is already visible via LogDebug above.
if (!logger.IsEnabled(LogLevel.Debug))
{
if (!string.IsNullOrWhiteSpace(stdout))
{
logger.LogError("{Stdout}", stdout);
}

if (!string.IsNullOrWhiteSpace(stderr))
{
logger.LogError("{StdErr}", stderr);
}
}

throw new InvalidBuildToolException(p.Id, stdout, stderr, $"{toolName} execution failed with exit code {p.ExitCode}");
}

Expand Down