Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

specjbb parser parses N/A metrics gracefully #346

Merged
merged 3 commits into from
Jan 21, 2025
Merged

specjbb parser parses N/A metrics gracefully #346

merged 3 commits into from
Jan 21, 2025

Conversation

nmalkapuram
Copy link
Contributor

yangpanMS
yangpanMS requested changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@yangpanMS yangpanMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refactor to use double.NaN for not valid result. Also when will we have nan output?

@yangpanMS
Copy link
Contributor

Do we still need this? Can I close it?

@yangpanMS yangpanMS marked this pull request as draft August 20, 2024 18:47
@yangpanMS
Copy link
Contributor

Closing. Please reopen as needed.

@yangpanMS yangpanMS closed this Oct 28, 2024
@nmalkapuram nmalkapuram reopened this Jan 9, 2025
@nmalkapuram nmalkapuram marked this pull request as ready for review January 9, 2025 09:42
yangpanMS
yangpanMS requested changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@yangpanMS yangpanMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the constructor will immediately break internal repo and partner extensions. Let's make sure this is necessary before proceeding.

@nmalkapuram nmalkapuram force-pushed the users/nmalkapuram/SpecjbbParserFix branch from 78fba99 to b96bfcf Compare January 20, 2025 16:00
@nmalkapuram
not emitting N/A values for now.Adding a metric that shows Metric is …
2999d5e 
…N/A explicitly. Actual resolution is fixing specjbb process for not emitting N/A values
@nmalkapuram nmalkapuram force-pushed the users/nmalkapuram/SpecjbbParserFix branch from b96bfcf to 2999d5e Compare January 20, 2025 16:04
@nmalkapuram nmalkapuram force-pushed the users/nmalkapuram/SpecjbbParserFix branch from 4bab5eb to 7b4fefc Compare January 21, 2025 04:35
@nmalkapuram nmalkapuram merged commit 5e0d23b into main Jan 21, 2025
5 checks passed
@nmalkapuram nmalkapuram deleted the users/nmalkapuram/SpecjbbParserFix branch January 21, 2025 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexffrank alexffrank alexffrank approved these changes

@yangpanMS yangpanMS yangpanMS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nmalkapuram @yangpanMS @alexffrank