Report error for invalid 'this' type during 'await' #48946

rbuckton · 2022-05-04T02:53:34Z

sandersn

Looks good, although I would personally collapse the two error parameters into one since they seem to be mutually exclusive.

sandersn · 2022-05-05T17:45:54Z

src/compiler/checker.ts

@@ -36256,7 +36256,7 @@ namespace ts {
         * @param type The type of the promise.
         * @remarks The "promised type" of a type is the type of the "value" parameter of the "onfulfilled" callback.
         */
-        function getPromisedTypeOfPromise(type: Type, errorNode?: Node): Type | undefined {
+        function getPromisedTypeOfPromise(type: Type, errorNode?: Node, thisTypeForErrorOut?: { value?: Type }): Type | undefined {


Probably should be a union since you don't want to issue the error twice, and the only place thisTypeForErrorOut is added did not previously pass errorNode.

I don't want to have to test whether errorNode is a Node and I'd also rather not allocate a nursery object for { errorNode } if I don't have to.

rbuckton · 2022-05-05T20:42:48Z

@DanielRosenwasser worth taking for 4.7? If so I can merge now.

rbuckton · 2022-05-05T20:52:43Z

@typescript-bot test this
@typescript-bot user test this

typescript-bot · 2022-05-05T20:52:46Z

Heya @rbuckton, I've started to run the parallelized community code test suite on this PR at 0b6ad03. You can monitor the build here.

typescript-bot · 2022-05-05T20:52:46Z

Heya @rbuckton, I've started to run the extended test suite on this PR at 0b6ad03. You can monitor the build here.

DanielRosenwasser · 2022-05-05T20:54:48Z

@typescript-bot user test this inline
@typescript-bot perf test faster

typescript-bot · 2022-05-05T20:54:50Z

Heya @DanielRosenwasser, I've started to run the diff-based community code test suite on this PR at 0b6ad03. You can monitor the build here.

Update: The results are in!

typescript-bot · 2022-05-05T20:54:50Z

Heya @DanielRosenwasser, I've started to run the abridged perf test suite on this PR at 0b6ad03. You can monitor the build here.

Update: The results are in!

typescript-bot · 2022-05-05T21:08:54Z

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..48946

_Metric	_main	₄₈₉₄₆	_Delta	_Best	_Worst
_{Angular - node (v14.15.1, x64)}
_{Memory used}	_{333,432k (± 0.01%)}	_{333,547k (± 0.01%)}	_{+115k (+ 0.03%)}	_333,514k	_333,618k
_{Parse Time}	_{2.02s (± 0.70%)}	_{2.05s (± 0.54%)}	_{+0.02s (+ 1.19%)}	_2.03s	_2.07s
_{Bind Time}	_{0.87s (± 0.77%)}	_{0.87s (± 0.46%)}	_{-0.00s (- 0.46%)}	_0.86s	_0.88s
_{Check Time}	_{5.63s (± 0.37%)}	_{5.64s (± 0.40%)}	_{+0.01s (+ 0.12%)}	_5.59s	_5.68s
_{Emit Time}	_{6.31s (± 0.50%)}	_{6.31s (± 0.70%)}	_{-0.00s (- 0.02%)}	_6.24s	_6.42s
_{Total Time}	_{14.84s (± 0.35%)}	_{14.87s (± 0.38%)}	_{+0.03s (+ 0.17%)}	_14.74s	_14.99s
_{Compiler-Unions - node (v14.15.1, x64)}
_{Memory used}	_{192,034k (± 0.13%)}	_{192,205k (± 0.01%)}	_{+171k (+ 0.09%)}	_192,153k	_192,266k
_{Parse Time}	_{0.86s (± 0.43%)}	_{0.85s (± 0.68%)}	_{-0.01s (- 1.05%)}	_0.84s	_0.86s
_{Bind Time}	_{0.56s (± 0.59%)}	_{0.56s (± 0.65%)}	_{-0.00s (- 0.71%)}	_0.55s	_0.56s
_{Check Time}	_{7.48s (± 0.59%)}	_{7.51s (± 0.30%)}	_{+0.03s (+ 0.37%)}	_7.47s	_7.55s
_{Emit Time}	_{2.53s (± 1.21%)}	_{2.51s (± 1.30%)}	_{-0.02s (- 0.75%)}	_2.45s	_2.61s
_{Total Time}	_{11.43s (± 0.46%)}	_{11.42s (± 0.33%)}	_{-0.01s (- 0.06%)}	_11.32s	_11.51s
_{Monaco - node (v14.15.1, x64)}
_{Memory used}	_{325,505k (± 0.01%)}	_{325,609k (± 0.01%)}	_{+104k (+ 0.03%)}	_325,556k	_325,661k
_{Parse Time}	_{1.57s (± 0.63%)}	_{1.58s (± 0.61%)}	_{+0.00s (+ 0.19%)}	_1.56s	_1.60s
_{Bind Time}	_{0.77s (± 0.47%)}	_{0.78s (± 1.00%)}	_{+0.01s (+ 0.65%)}	_0.76s	_0.80s
_{Check Time}	_{5.56s (± 0.53%)}	_{5.51s (± 0.32%)}	_{-0.05s (- 0.94%)}	_5.47s	_5.54s
_{Emit Time}	_{3.32s (± 0.55%)}	_{3.32s (± 0.94%)}	_{-0.00s (- 0.09%)}	_3.28s	_3.43s
_{Total Time}	_{11.23s (± 0.40%)}	_{11.18s (± 0.32%)}	_{-0.04s (- 0.38%)}	_11.12s	_11.27s
_{TFS - node (v14.15.1, x64)}
_{Memory used}	_{289,078k (± 0.00%)}	_{289,130k (± 0.01%)}	_{+52k (+ 0.02%)}	_289,070k	_289,181k
_{Parse Time}	_{1.37s (± 1.11%)}	_{1.36s (± 1.29%)}	_{-0.00s (- 0.22%)}	_1.34s	_1.42s
_{Bind Time}	_{0.72s (± 0.41%)}	_{0.72s (± 0.97%)}	_{-0.00s (- 0.14%)}	_0.71s	_0.74s
_{Check Time}	_{5.20s (± 0.44%)}	_{5.20s (± 0.54%)}	_{+0.00s (+ 0.08%)}	_5.14s	_5.26s
_{Emit Time}	_{3.54s (± 1.76%)}	_{3.55s (± 2.06%)}	_{+0.01s (+ 0.31%)}	_3.39s	_3.65s
_{Total Time}	_{10.83s (± 0.75%)}	_{10.84s (± 0.66%)}	_{+0.01s (+ 0.10%)}	_10.67s	_11.01s
_{material-ui - node (v14.15.1, x64)}
_{Memory used}	_{447,804k (± 0.00%)}	_{447,540k (± 0.00%)}	_{-264k (- 0.06%)}	_447,495k	_447,569k
_{Parse Time}	_{1.86s (± 0.62%)}	_{1.87s (± 0.53%)}	_{+0.01s (+ 0.43%)}	_1.85s	_1.90s
_{Bind Time}	_{0.70s (± 0.95%)}	_{0.70s (± 0.74%)}	_{-0.00s (- 0.14%)}	_0.69s	_0.71s
_{Check Time}	_{13.04s (± 0.57%)}	_{13.08s (± 1.05%)}	_{+0.05s (+ 0.38%)}	_12.88s	_13.51s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{15.60s (± 0.56%)}	_{15.65s (± 0.91%)}	_{+0.05s (+ 0.35%)}	_15.44s	_16.09s
_{xstate - node (v14.15.1, x64)}
_{Memory used}	_{535,910k (± 0.00%)}	_{535,158k (± 0.00%)}	_{-752k (- 0.14%)}	_535,106k	_535,188k
_{Parse Time}	_{2.59s (± 0.52%)}	_{2.58s (± 0.46%)}	_{-0.01s (- 0.46%)}	_2.56s	_2.62s
_{Bind Time}	_{1.14s (± 0.65%)}	_{1.14s (± 1.16%)}	_{0.00s ( 0.00%)}	_1.12s	_1.18s
_{Check Time}	_{1.51s (± 0.38%)}	_{1.51s (± 0.33%)}	_{-0.01s (- 0.46%)}	_1.50s	_1.52s
_{Emit Time}	_{0.07s (± 0.00%)}	_{0.07s (± 0.00%)}	_{0.00s ( 0.00%)}	_0.07s	_0.07s
_{Total Time}	_{5.32s (± 0.22%)}	_{5.31s (± 0.30%)}	_{-0.01s (- 0.28%)}	_5.27s	_5.35s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 4.4.0-210-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{2 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v14.15.1, x64)

Scenarios

Angular - node (v14.15.1, x64)
Compiler-Unions - node (v14.15.1, x64)
Monaco - node (v14.15.1, x64)
TFS - node (v14.15.1, x64)
material-ui - node (v14.15.1, x64)
xstate - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₄₈₉₄₆	₁₀
_Baseline	_main	₁₀

Developer Information:

Download Benchmark

typescript-bot · 2022-05-05T21:18:10Z

@DanielRosenwasser
Great news! no new errors were found between main..refs/pull/48946/merge

typescript-bot · 2022-05-05T21:55:45Z

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

rbuckton requested review from sandersn and weswigham May 4, 2022 02:53

typescript-bot assigned rbuckton May 4, 2022

typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels May 4, 2022

Report error for invalid 'this' type during 'await'

0b6ad03

rbuckton force-pushed the fix47711 branch from bce92ab to 0b6ad03 Compare May 5, 2022 16:57

sandersn approved these changes May 5, 2022

View reviewed changes

typescript-bot mentioned this pull request May 5, 2022

🤖 User test baselines have changed for fix47711 typescript-bot/TypeScript#235

Open

rbuckton merged commit e2bd89b into main May 9, 2022

rbuckton deleted the fix47711 branch May 9, 2022 20:58

rbuckton restored the fix47711 branch May 9, 2022 20:58

jakebailey deleted the fix47711 branch November 7, 2022 17:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Report error for invalid 'this' type during 'await' #48946

Report error for invalid 'this' type during 'await' #48946

rbuckton commented May 4, 2022

sandersn left a comment

sandersn May 5, 2022

rbuckton May 5, 2022

rbuckton commented May 5, 2022

rbuckton commented May 5, 2022

typescript-bot commented May 5, 2022 •

edited

Loading

typescript-bot commented May 5, 2022 •

edited

Loading

DanielRosenwasser commented May 5, 2022

typescript-bot commented May 5, 2022 •

edited

Loading

typescript-bot commented May 5, 2022 •

edited

Loading

typescript-bot commented May 5, 2022

typescript-bot commented May 5, 2022

typescript-bot commented May 5, 2022

Report error for invalid 'this' type during 'await' #48946

Report error for invalid 'this' type during 'await' #48946

Conversation

rbuckton commented May 4, 2022

sandersn left a comment

Choose a reason for hiding this comment

sandersn May 5, 2022

Choose a reason for hiding this comment

rbuckton May 5, 2022

Choose a reason for hiding this comment

rbuckton commented May 5, 2022

rbuckton commented May 5, 2022

typescript-bot commented May 5, 2022 • edited Loading

typescript-bot commented May 5, 2022 • edited Loading

DanielRosenwasser commented May 5, 2022

typescript-bot commented May 5, 2022 • edited Loading

typescript-bot commented May 5, 2022 • edited Loading

typescript-bot commented May 5, 2022

typescript-bot commented May 5, 2022

typescript-bot commented May 5, 2022

typescript-bot commented May 5, 2022 •

edited

Loading

typescript-bot commented May 5, 2022 •

edited

Loading

typescript-bot commented May 5, 2022 •

edited

Loading

typescript-bot commented May 5, 2022 •

edited

Loading