Prevent crash on code fixes on default keyword #48028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Milestone Bug
14h
reviewed
Feb 25, 2022
|
|
||
| // "default" is a keyword and not a legal identifier for the import, but appears as an identifier. | ||
| if (symbolName === InternalSymbolName.Default) { | ||
| return undefined; |
There was a problem hiding this comment.
Suggested change
| return undefined; | |
| return; | |
There was a problem hiding this comment.
While technically equivalent, I don't think an implicit undefined return is very clear (and this codebase doesn't really do this).
jakebailey
changed the title
sandersn
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48008
defaultappears as an identifier in the AST, which appears to be expected. Just returnundefinedto skip the symbol rather than asserting that it's not legal.