Fix error and error-behind css classes out-of-sync #3400
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
error-behind
in some cases line breaks beforeerror
does, e.g. in docs/handbook/2/objects.html:you can see
of the
error-behind
, which is supposed to be invisible, in the next line.The problem is that the CSS classes
error
andbehind-error
are slightly out of sync:margin-right: -2px
is obsoleteerror
should be6px 8px 6px 12px
6px 6px 6px 14px
, but14px
is too much since the ancestor<pre class="shiki light-plus twoslash lsp" ...>
has a border of1px
+12px
paddingerror
class has aborder-right: 2px
which hangs1px
over the border of the<pre>
element, the padding should be12px
8px
compensates the removedmargin-right: -2px
error-behind
span line breaks before theerror
spanerror
is absolute, it ignores the right padding of the ancestor<pre>
of12px
error
needs amargin-right: 12px
to wrap simultaneously