-
Notifications
You must be signed in to change notification settings - Fork 455
Fix overrides for non-shared ArrayBuffer views #2206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix overrides for non-shared ArrayBuffer views #2206
Conversation
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
|
Interesting, LGTM |
|
There was an issue merging, maybe try again saschanaz. Details |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hope this doesn't break people even more 😄
|
LGTM |
|
There was an issue merging, maybe try again saschanaz. Details |
|
What? 🙄 lgtm |
|
There was an issue merging, maybe try again saschanaz. Details |
|
I rotated a bunch of tokens, maybe I broke this one. Will fix soon |
|
Can you try again? |
|
LGTM |
|
There was an issue merging, maybe try again saschanaz. Details |
|
Okay, well that's quite confusing. |
|
The token I rotated isn't even the one used by this workflow, which is just the regular github actions token. Weird. Maybe they broke yet another thing in the workflow :( I'll just merge it. |
|
This is why I need a real permission rather than a workflow workaround |
Fixes a couple of divergences from the specifications:
WebSocket#send()was previously overridden back in 2018 to accept shared array buffers and array buffer views. The parameter isn't[AllowShared]in the specification, so this is simply inaccurate.extendsclause of a couple of interface methods is currently set toArrayBufferViewwhen it should beArrayBufferView<ArrayBuffer>. Becauseextendsis a manually defined field, it doesn't honour useGenericTypedArrays, so this needs to be indirectly resolved for compatibility with TS 5.6 and earlier.