Simplify / fix HTMLCollection overrides #2079
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ingvar Stepanyan <[email protected]>
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
saschanaz
reviewed
Jul 26, 2025
| @@ -789,7 +789,7 @@ interface MessagePortEventMap extends MessageEventTargetEventMap { | |||
| * | |||
| * [MDN Reference](https://developer.mozilla.org/docs/Web/API/MessagePort) | |||
| */ | |||
| interface MessagePort extends EventTarget, MessageEventTarget<MessagePort> { | |||
There was a problem hiding this comment.
Any idea why this change happened?
There was a problem hiding this comment.
Idk ... Maybe I broke the emitter with my changes. I will try to revert most of my change to the emitter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #813 by reviving and completing the implementation from the original PR.
Co-authored-by: Ingvar Stepanyan[email protected]