Skip to content

Fixes the type of self in WorkerGlobalScope #2030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fixes the type of self in WorkerGlobalScope #2030

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a330bf
fix: update overrideType for ServiceWorkerGlobalScope in overridingTy…
Bashamega May 30, 2025
122830b
-
Bashamega May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions baselines/serviceworker.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8599,7 +8599,7 @@ interface WorkerGlobalScope extends EventTarget, FontFaceSource, WindowOrWorkerG
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WorkerGlobalScope/self)
*/
readonly self: WorkerGlobalScope & typeof globalThis;
readonly self: ServiceWorkerGlobalScope & typeof globalThis;
/**
* Fetches each URL in urls, executes them one-by-one in the order they are passed, and then returns (or throws if something went amiss).
*
Expand Down Expand Up @@ -9073,7 +9073,7 @@ declare var onunhandledrejection: ((this: ServiceWorkerGlobalScope, ev: PromiseR
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WorkerGlobalScope/self)
*/
declare var self: WorkerGlobalScope & typeof globalThis;
declare var self: ServiceWorkerGlobalScope & typeof globalThis;
/**
* Fetches each URL in urls, executes them one-by-one in the order they are passed, and then returns (or throws if something went amiss).
*
Expand Down
4 changes: 2 additions & 2 deletions baselines/sharedworker.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8334,7 +8334,7 @@ interface WorkerGlobalScope extends EventTarget, FontFaceSource, WindowOrWorkerG
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WorkerGlobalScope/self)
*/
readonly self: WorkerGlobalScope & typeof globalThis;
readonly self: ServiceWorkerGlobalScope & typeof globalThis;
/**
* Fetches each URL in urls, executes them one-by-one in the order they are passed, and then returns (or throws if something went amiss).
*
Expand Down Expand Up @@ -8989,7 +8989,7 @@ declare var onunhandledrejection: ((this: SharedWorkerGlobalScope, ev: PromiseRe
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WorkerGlobalScope/self)
*/
declare var self: WorkerGlobalScope & typeof globalThis;
declare var self: ServiceWorkerGlobalScope & typeof globalThis;
/**
* Fetches each URL in urls, executes them one-by-one in the order they are passed, and then returns (or throws if something went amiss).
*
Expand Down
4 changes: 2 additions & 2 deletions baselines/ts5.5/serviceworker.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8599,7 +8599,7 @@ interface WorkerGlobalScope extends EventTarget, FontFaceSource, WindowOrWorkerG
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WorkerGlobalScope/self)
*/
readonly self: WorkerGlobalScope & typeof globalThis;
readonly self: ServiceWorkerGlobalScope & typeof globalThis;
/**
* Fetches each URL in urls, executes them one-by-one in the order they are passed, and then returns (or throws if something went amiss).
*
Expand Down Expand Up @@ -9073,7 +9073,7 @@ declare var onunhandledrejection: ((this: ServiceWorkerGlobalScope, ev: PromiseR
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WorkerGlobalScope/self)
*/
declare var self: WorkerGlobalScope & typeof globalThis;
declare var self: ServiceWorkerGlobalScope & typeof globalThis;
/**
* Fetches each URL in urls, executes them one-by-one in the order they are passed, and then returns (or throws if something went amiss).
*
Expand Down
4 changes: 2 additions & 2 deletions baselines/ts5.5/sharedworker.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8334,7 +8334,7 @@ interface WorkerGlobalScope extends EventTarget, FontFaceSource, WindowOrWorkerG
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WorkerGlobalScope/self)
*/
readonly self: WorkerGlobalScope & typeof globalThis;
readonly self: ServiceWorkerGlobalScope & typeof globalThis;
/**
* Fetches each URL in urls, executes them one-by-one in the order they are passed, and then returns (or throws if something went amiss).
*
Expand Down Expand Up @@ -8989,7 +8989,7 @@ declare var onunhandledrejection: ((this: SharedWorkerGlobalScope, ev: PromiseRe
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WorkerGlobalScope/self)
*/
declare var self: WorkerGlobalScope & typeof globalThis;
declare var self: ServiceWorkerGlobalScope & typeof globalThis;
/**
* Fetches each URL in urls, executes them one-by-one in the order they are passed, and then returns (or throws if something went amiss).
*
Expand Down
4 changes: 2 additions & 2 deletions baselines/ts5.5/webworker.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9567,7 +9567,7 @@ interface WorkerGlobalScope extends EventTarget, FontFaceSource, WindowOrWorkerG
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WorkerGlobalScope/self)
*/
readonly self: WorkerGlobalScope & typeof globalThis;
readonly self: ServiceWorkerGlobalScope & typeof globalThis;
/**
* Fetches each URL in urls, executes them one-by-one in the order they are passed, and then returns (or throws if something went amiss).
*
Expand Down Expand Up @@ -10253,7 +10253,7 @@ declare var onunhandledrejection: ((this: DedicatedWorkerGlobalScope, ev: Promis
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WorkerGlobalScope/self)
*/
declare var self: WorkerGlobalScope & typeof globalThis;
declare var self: ServiceWorkerGlobalScope & typeof globalThis;
/**
* Fetches each URL in urls, executes them one-by-one in the order they are passed, and then returns (or throws if something went amiss).
*
Expand Down
4 changes: 2 additions & 2 deletions baselines/ts5.6/serviceworker.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8599,7 +8599,7 @@ interface WorkerGlobalScope extends EventTarget, FontFaceSource, WindowOrWorkerG
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WorkerGlobalScope/self)
*/
readonly self: WorkerGlobalScope & typeof globalThis;
readonly self: ServiceWorkerGlobalScope & typeof globalThis;
/**
* Fetches each URL in urls, executes them one-by-one in the order they are passed, and then returns (or throws if something went amiss).
*
Expand Down Expand Up @@ -9073,7 +9073,7 @@ declare var onunhandledrejection: ((this: ServiceWorkerGlobalScope, ev: PromiseR
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WorkerGlobalScope/self)
*/
declare var self: WorkerGlobalScope & typeof globalThis;
declare var self: ServiceWorkerGlobalScope & typeof globalThis;
/**
* Fetches each URL in urls, executes them one-by-one in the order they are passed, and then returns (or throws if something went amiss).
*
Expand Down
4 changes: 2 additions & 2 deletions baselines/ts5.6/sharedworker.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8334,7 +8334,7 @@ interface WorkerGlobalScope extends EventTarget, FontFaceSource, WindowOrWorkerG
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WorkerGlobalScope/self)
*/
readonly self: WorkerGlobalScope & typeof globalThis;
readonly self: ServiceWorkerGlobalScope & typeof globalThis;
/**
* Fetches each URL in urls, executes them one-by-one in the order they are passed, and then returns (or throws if something went amiss).
*
Expand Down Expand Up @@ -8989,7 +8989,7 @@ declare var onunhandledrejection: ((this: SharedWorkerGlobalScope, ev: PromiseRe
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WorkerGlobalScope/self)
*/
declare var self: WorkerGlobalScope & typeof globalThis;
declare var self: ServiceWorkerGlobalScope & typeof globalThis;
/**
* Fetches each URL in urls, executes them one-by-one in the order they are passed, and then returns (or throws if something went amiss).
*
Expand Down
4 changes: 2 additions & 2 deletions baselines/ts5.6/webworker.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9567,7 +9567,7 @@ interface WorkerGlobalScope extends EventTarget, FontFaceSource, WindowOrWorkerG
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WorkerGlobalScope/self)
*/
readonly self: WorkerGlobalScope & typeof globalThis;
readonly self: ServiceWorkerGlobalScope & typeof globalThis;
/**
* Fetches each URL in urls, executes them one-by-one in the order they are passed, and then returns (or throws if something went amiss).
*
Expand Down Expand Up @@ -10253,7 +10253,7 @@ declare var onunhandledrejection: ((this: DedicatedWorkerGlobalScope, ev: Promis
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WorkerGlobalScope/self)
*/
declare var self: WorkerGlobalScope & typeof globalThis;
declare var self: ServiceWorkerGlobalScope & typeof globalThis;
/**
* Fetches each URL in urls, executes them one-by-one in the order they are passed, and then returns (or throws if something went amiss).
*
Expand Down
4 changes: 2 additions & 2 deletions baselines/webworker.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9567,7 +9567,7 @@ interface WorkerGlobalScope extends EventTarget, FontFaceSource, WindowOrWorkerG
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WorkerGlobalScope/self)
*/
readonly self: WorkerGlobalScope & typeof globalThis;
readonly self: ServiceWorkerGlobalScope & typeof globalThis;
/**
* Fetches each URL in urls, executes them one-by-one in the order they are passed, and then returns (or throws if something went amiss).
*
Expand Down Expand Up @@ -10253,7 +10253,7 @@ declare var onunhandledrejection: ((this: DedicatedWorkerGlobalScope, ev: Promis
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WorkerGlobalScope/self)
*/
declare var self: WorkerGlobalScope & typeof globalThis;
declare var self: ServiceWorkerGlobalScope & typeof globalThis;
/**
* Fetches each URL in urls, executes them one-by-one in the order they are passed, and then returns (or throws if something went amiss).
*
Expand Down
2 changes: 1 addition & 1 deletion inputfiles/overridingTypes.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3340,7 +3340,7 @@
"properties": {
"property": {
"self": {
"overrideType": "WorkerGlobalScope & typeof globalThis"
"overrideType": "ServiceWorkerGlobalScope & typeof globalThis"
}
}
},
Expand Down
Loading