Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cell): Move the definition of BaseTile into types to facilitate further refactoring. #53

Merged
merged 3 commits into from
Feb 13, 2025
Merged

fix(cell): Move the definition of BaseTile into types to facilitate further refactoring. #53

merged 3 commits into from
Feb 13, 2025

Conversation

lcy-seso
Copy link
Contributor

@lcy-seso lcy-seso commented Feb 13, 2025 •
edited
Loading

This pull request doesn't introduce any new functionality; rather, it makes the following adjustments:

  1. It moves the definition of BaseTile to the types file to facilitate upcoming refactoring.
  2. It initializes the document for the shared memory layout.

@lcy-seso lcy-seso requested a review from KuangjuX February 13, 2025 10:37
@lcy-seso lcy-seso changed the title fix(cell): Move the definition of BaseTile into types. fix(cell): Move the definition of BaseTile into types to facilitate further refactoring. Feb 13, 2025
KuangjuX
KuangjuX approved these changes Feb 13, 2025
View reviewed changes
Copy link
Collaborator

@KuangjuX KuangjuX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KuangjuX KuangjuX merged commit 280ecd8 into microsoft:master Feb 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KuangjuX KuangjuX KuangjuX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lcy-seso @KuangjuX