ReImplement SMEM to RMEM Based on SwizzledLayout
#51
Conversation
include/cell/copy/warp.hpp
Outdated
| @@ -397,9 +396,12 @@ struct SharedOffsetHelper<WarpLayout_, WarpShape_, Shared_, kMode_, | |||
| constexpr static int kTilePerRow = Shared::kRows / WarpShape::kRows; | |||
| constexpr static int kTilePerCol = Shared::kCols / WarpShape::kCols; | |||
|
|
|||
| // constexpr static int kRowStride = kTilePerRow / tl::num_rows<WarpLayout>; | |||
| // constexpr static int kColStride = | |||
| // kTilePerCol / tl::num_cols<WarpLayout> * kTilePerRow; | |||
There was a problem hiding this comment.
Are lines 399 ~ 401 no longer useful, thus can be deleted?
There was a problem hiding this comment.
Deleted useless codes.
| // using Shared = SharedTile<Element, tl::RowMajor<16, 16>>; | ||
| using Shared = SharedTile<Element, tl::RowMajor<64, 128>>; | ||
| // using Reg = RegTile<BaseTileRowMajor<Element>, tl::RowMajor<1, 1>>; | ||
| using Reg = RegTile<BaseTileRowMajor<Element>, tl::RowMajor<4, 8>>; |
There was a problem hiding this comment.
Could you please explain why lines 157, 161, 167, 187, 192, 220, and 222 have been commented out?
There was a problem hiding this comment.
Because I want to use the WarpLayout format which is more suitable for the current implementation.
tests/cpp/cell/test_s2r_copy.cu
Outdated
|
|
||
| using SharedLayout = tl::RowMajor<kRows, kCols>; | ||
| const bool kUseSwizzledLayout = true; | ||
| using Shared = SharedTile<Element, SharedLayout, kUseSwizzledLayout>; | ||
| using Reg = RegTile<BaseTileRowMajor<Element>, tl::RowMajor<2, 2>>; | ||
| // using Reg = RegTile<BaseTileRowMajor<Element>, tl::RowMajor<2, 2>>; |
There was a problem hiding this comment.
Would combining lines 246–247 with line 255 produce a unit test case that's worth adding to the tests, or does it simply duplicate an existing test case?
There was a problem hiding this comment.
Deleted useless codes.
tests/cpp/cell/test_s2r_copy.cu
Outdated
| const int kWarpPerRow = 2; | ||
| const int kWarpPerCol = 2; | ||
| // const int kWarpPerRow = 2; | ||
| // const int kWarpPerCol = 2; |
There was a problem hiding this comment.
Do the test cases on lines 276–277 and 281–282 provide unique coverage worthy of being added to the tests, or do they simply duplicate existing tests?
If they offer unique coverage, please leave them in the comments; otherwise, they should be removed.
There was a problem hiding this comment.
Deleted useless codes.
tests/cpp/cell/test_single_wmma.cu
Outdated
| run_test<96, 48, 80>(); | ||
| // run_test<16, 16, 16>(); // Test the `BaseTile` 16x16x16 | ||
| // run_test<16, 32, 16>(); | ||
| // run_test<96, 48, 80>(); |
There was a problem hiding this comment.
Please add a comment explaining why these test cases are commented out if they're intended to provide unique coverage but aren't supported yet. Otherwise, delete them if they're not needed.
There was a problem hiding this comment.
Deleted useless codes.
Progress:
Swizzle<3, 3, 3>.STileIteratorto enable traversal based on the Swizzle layout.floatdata type for R2S Storer.WarpLayoutconfigurations.