Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sign and path for Keyboard Manager Editor #37620

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update sign and path for Keyboard Manager Editor #37620

wants to merge 1 commit into from
+2 −1

Conversation

haoliuu
Copy link
Contributor

@haoliuu haoliuu commented Feb 25, 2025

Summary of the Pull Request

  1. Sign the KeyboardManagerEditorUI.exe
  2. Update the Library wrapper DLL import path since it's renamed as PowerToys.KeyboardManagerEditorLibraryWrapper.dll in [ci]Sign and fix KeyboardManagerEditorLibraryWrapper.dll #37601

PR Checklist

  • Closes: #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

@haoliuu haoliuu requested a review from a team as a code owner February 25, 2025 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaimecbernardo jaimecbernardo Awaiting requested review from jaimecbernardo

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@haoliuu