Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspaces] Fix snapshotting minimized apps #37598

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

donlaci
Copy link
Collaborator

@donlaci donlaci commented Feb 24, 2025

Summary of the Pull Request

Some minimized packaged apps (Microsoft ToDo, Settings) were not snapshotted. This PR fixes the issue

PR Checklist

Detailed Description of the Pull Request / Additional comments

Fixing filter used when enumerating through all the windows. With the fix, the minimized packaged apps are not filtered out.

Validation Steps Performed

tested locally

Copy link
Collaborator

@SeraphimaZykova SeraphimaZykova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!
With those changes, minimized apps are captured. Tested with Settings, Microsoft ToDo, Clock, Camera, Calculator.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (3)
  • src/modules/Workspaces/WorkspacesSnapshotTool/SnapshotUtils.cpp: Language not supported
  • src/modules/Workspaces/WorkspacesWindowArranger/WindowArranger.cpp: Language not supported
  • src/modules/Workspaces/workspaces-common/WindowFilter.h: Language not supported
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants