-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Powertoys Run] Disable CETCompat in Launcher #37550
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good and the user confirmed it fixes the issue. Before we merge it lets just add a comment there to reference the issue and explain why we added It
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to make sure this is safe to do
https://learn.microsoft.com/en-us/dotnet/core/compatibility/interop/9.0/cet-support .net 9 turned it on by default |
Summary of the Pull Request
Disable of CETCompat due to some users having crashes when loading thumbnails after the update to .net9.
PR Checklist
Detailed Description of the Pull Request / Additional comments
.Net guys suggested we disable CETCompat dotnet/wpf#10483 (comment) to fix this issue. User confirmed the fix worked for him.
For some users ExtractAssociatedIcon crashes 100% of the time without this change.
Validation Steps Performed
Tested on W11.