Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable MTP #37001

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from
Draft

Enable MTP #37001

wants to merge 19 commits into from

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Jan 22, 2025

Summary of the Pull Request

Update MSTest to latest and switch to Microsoft.Testing.Platform instead of VSTest.

PR Checklist

  • Closes: #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@Youssef1313 Youssef1313 marked this pull request as draft January 22, 2025 05:13
@Youssef1313
Copy link
Member Author

I'm not seeing a build triggered on this PR. Is CI for this repo manually triggered?

@Youssef1313 Youssef1313 marked this pull request as ready for review January 22, 2025 05:21
@Youssef1313 Youssef1313 requested a review from a team as a code owner January 22, 2025 05:48
@crutkas
Copy link
Member

crutkas commented Jan 22, 2025

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@crutkas
Copy link
Member

crutkas commented Jan 22, 2025

@Youssef1313 can you ping me internally? I would love to ask a few questions on this.

@DHowett as FYI

@jaimecbernardo
Copy link
Collaborator

Thanks for opening this PR. CI is failing because of some XAML style errors that got into main. Please merge latest main in to fix that. Thank you

@Youssef1313
Copy link
Member Author

/azp run

Copy link

Commenter does not have sufficient privileges for PR 37001 in repo microsoft/PowerToys

@crutkas
Copy link
Member

crutkas commented Jan 22, 2025

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Youssef1313 Youssef1313 marked this pull request as draft January 22, 2025 17:40
@Youssef1313
Copy link
Member Author

@crutkas Could you run the pipeline please? Thanks!

@crutkas
Copy link
Member

crutkas commented Jan 27, 2025

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Youssef1313
Copy link
Member Author

C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Microsoft\VC\v170\Microsoft.CppBuild.targets(473,5): error MSB8070: Cannot find MSVC toolset version '14.42.34436': the folder 'C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.42.34436\' does not exist. Please make sure MSVC toolset version '14.42.34436' is  installed or choose another toolset version. [D:\a\_work\1\s\src\common\Telemetry\EtwTrace\EtwTrace.vcxproj]

@crutkas @jaimecbernardo Is this related to #37098?

@jaimecbernardo
Copy link
Collaborator

Yes @Youssef1313 , please merge latest main to fix :)

@Youssef1313
Copy link
Member Author

Thank you. Could you please run the pipeline again?

@crutkas
Copy link
Member

crutkas commented Jan 29, 2025

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Youssef1313
Copy link
Member Author

@crutkas I pushed some more changes

@crutkas
Copy link
Member

crutkas commented Jan 29, 2025

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@crutkas
Copy link
Member

crutkas commented Jan 30, 2025

/azp run

Copy link

Azure Pipelines failed to run 1 pipeline(s).

@Youssef1313
Copy link
Member Author

@crutkas I did more changes if you can re-run the pipeline again please

@DHowett
Copy link
Member

DHowett commented Jan 30, 2025

/azp run

Copy link

Azure Pipelines failed to run 1 pipeline(s).

@Youssef1313
Copy link
Member Author

@DHowett @crutkas Could you please run the pipeline here? Thanks!

@crutkas
Copy link
Member

crutkas commented Feb 18, 2025

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Youssef1313
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (1)

dnceng

These words are not needed and should be removed ahk AMPROPERTY AMPROPSETID Breadcrumb CDEF comdef ddf devenum DEVMON DEVSOURCE DGR DIIRFLAG dshow DVH DVHD DVSD DVSL EData ERole fdw FILEINFOSIG Filtergraph Filterx HCERTSTORE IKs iljxck IYUV KSPROPERTY lcb ldx lld LONGLONG LTRB majortype makecab MEDIASUBTYPE mediatype mfplat mic mjpg Msimg msiquery ORAW outpin overlaywindow PAUDIO PINDIR Pnp ppmt previouscamera PROPBAG propvarutil reencode reencoded REFGUID REGFILTER REGFILTERPINS REGPINTYPES regsvr shmem sizeread stl strsafe strutil subquery SYNCMFT TMPVAR vcdl vdi vid VIDCAP VIDEOINFOHEADER vih webcam wistd WVC

To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands

... in a clone of the [email protected]:Youssef1313/PowerToys.git repository
on the migrate-to-mtp branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.24/apply.pl' |
perl - 'https://github.com/microsoft/PowerToys/actions/runs/13516852801/attempts/1'
If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants