Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspaces] implement Launch on startup feature #36753

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

donlaci
Copy link
Collaborator

@donlaci donlaci commented Jan 8, 2025

Summary of the Pull Request

Adding checkbox to the editor for the feature.
When checked, a shortcut is created in the shell:startup folder, which is launched on system startup

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Tested locally

@donlaci donlaci closed this Jan 13, 2025
@donlaci donlaci reopened this Jan 13, 2025
@donlaci donlaci marked this pull request as draft January 13, 2025 16:57

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 10 changed files in this pull request and generated no comments.

Files not reviewed (5)
  • src/modules/Workspaces/WorkspacesEditor/Properties/Resources.Designer.cs: Language not supported
  • src/modules/Workspaces/WorkspacesEditor/Properties/Resources.resx: Language not supported
  • src/modules/Workspaces/WorkspacesEditor/WorkspacesEditorPage.xaml: Language not supported
  • src/modules/Workspaces/WorkspacesLib/WorkspacesData.cpp: Language not supported
  • src/modules/Workspaces/WorkspacesLib/WorkspacesData.h: Language not supported
Copy link
Collaborator

@SeraphimaZykova SeraphimaZykova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature is not fully implemented; it's a work in progress and not ready to be merged.

There is still no complete specification for this feature that also addresses security concerns.

There is a limitation: only one workspace can be launched at a time. So, if a user sets more than one workspace to launch at the startup, they'll encounter a bug where only one workspace is launched. Either a new tool should be implemented to launch all startup workspaces one after another, or this limitation should be handled in the editor, not allowing the launch of more than one workspace at the startup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants